Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755907AbYKTQmX (ORCPT ); Thu, 20 Nov 2008 11:42:23 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753518AbYKTQmG (ORCPT ); Thu, 20 Nov 2008 11:42:06 -0500 Received: from g1t0026.austin.hp.com ([15.216.28.33]:45245 "EHLO g1t0026.austin.hp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753471AbYKTQmE convert rfc822-to-8bit (ORCPT ); Thu, 20 Nov 2008 11:42:04 -0500 From: "Miller, Mike (OS Dev)" To: Jens Axboe CC: Randy Dunlap , scsi , James Bottomley , lkml , akpm Date: Thu, 20 Nov 2008 16:41:39 +0000 Subject: RE: in 2.6.23-rc3-git7 in do_cciss_intr Thread-Topic: in 2.6.23-rc3-git7 in do_cciss_intr Thread-Index: AclK8HN4ivTlDiTfRvalOkv4iWC1/wAPkMsQ Message-ID: <0F5B06BAB751E047AB5C87D1F77A77884EACB79F52@GVW0547EXC.americas.hpqcorp.net> References: <49232232.10604@oracle.com> <4923237B.9090707@xenotime.net> <4923347D.8000205@oracle.com> <20081119085227.GQ26308@kernel.dk> <0F5B06BAB751E047AB5C87D1F77A77884EACB7986A@GVW0547EXC.americas.hpqcorp.net> <49244B69.80903@oracle.com> <0F5B06BAB751E047AB5C87D1F77A77884EACB798C4@GVW0547EXC.americas.hpqcorp.net> <20081119172919.GT26308@kernel.dk> <0F5B06BAB751E047AB5C87D1F77A77884EACB799CC@GVW0547EXC.americas.hpqcorp.net> <20081119204624.GW26308@kernel.dk> <20081120091303.GF26308@kernel.dk> In-Reply-To: <20081120091303.GF26308@kernel.dk> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: acceptlanguage: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1136 Lines: 30 Jens wrote: > > > > I'd propose just converting it to list_head instead of doing it > > manually. Heck, that should be a 5 minute job, let me just do it... > > > > OK, here it is, totally untested (it compiles, must be golden...) > > It was missing a list_entry() in fail_all_cmds(), apart from > that it was fine. I changed it to use hlist instead, as that > is more appropriate and similar to how it worked before. It > also means there's no extra space usage in the controller > structure. I've tested it and it works fine for me. > > Mike, can you give this a look-over and give me a Reviewed-by > or similar? As an extra bonus, it also gets rid of some code. > > 3 files changed, 33 insertions(+), 46 deletions(-) > > http://git.kernel.dk/?p=linux-2.6-block.git;a=commit;h=e303054 > e55acd1b6478b8859a5f8648bfaf69a44 That works for me. :) Acked-by: Mike Miller -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/