Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756170AbYKTRpX (ORCPT ); Thu, 20 Nov 2008 12:45:23 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753348AbYKTRpK (ORCPT ); Thu, 20 Nov 2008 12:45:10 -0500 Received: from bombadil.infradead.org ([18.85.46.34]:38992 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752505AbYKTRpI (ORCPT ); Thu, 20 Nov 2008 12:45:08 -0500 Date: Thu, 20 Nov 2008 12:45:06 -0500 From: Christoph Hellwig To: Mimi Zohar Cc: linux-kernel@vger.kernel.org, Andrew Morton , James Morris , Christoph Hellwig , Al Viro , David Safford , Serge Hallyn , Mimi Zohar Subject: Re: [PATCH 2/4] integrity: Linux Integrity Module(LIM) Message-ID: <20081120174506.GA20972@infradead.org> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.18 (2008-05-17) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 473 Lines: 9 Ok, the API looks sane to me. But one big question: any reason you don't just directly call into your implementation instead of all these odd hooks? This seems to be a lot of overhead just for making the code less readable.. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/