Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756569AbYKTRwc (ORCPT ); Thu, 20 Nov 2008 12:52:32 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753471AbYKTRwW (ORCPT ); Thu, 20 Nov 2008 12:52:22 -0500 Received: from pasmtpa.tele.dk ([80.160.77.114]:50994 "EHLO pasmtpA.tele.dk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752505AbYKTRwW (ORCPT ); Thu, 20 Nov 2008 12:52:22 -0500 Date: Thu, 20 Nov 2008 18:50:30 +0100 From: Jens Axboe To: "Miller, Mike (OS Dev)" Cc: Randy Dunlap , scsi , James Bottomley , lkml , akpm Subject: Re: in 2.6.23-rc3-git7 in do_cciss_intr Message-ID: <20081120175029.GM26308@kernel.dk> References: <4923347D.8000205@oracle.com> <20081119085227.GQ26308@kernel.dk> <0F5B06BAB751E047AB5C87D1F77A77884EACB7986A@GVW0547EXC.americas.hpqcorp.net> <49244B69.80903@oracle.com> <0F5B06BAB751E047AB5C87D1F77A77884EACB798C4@GVW0547EXC.americas.hpqcorp.net> <20081119172919.GT26308@kernel.dk> <0F5B06BAB751E047AB5C87D1F77A77884EACB799CC@GVW0547EXC.americas.hpqcorp.net> <20081119204624.GW26308@kernel.dk> <20081120091303.GF26308@kernel.dk> <0F5B06BAB751E047AB5C87D1F77A77884EACB79F52@GVW0547EXC.americas.hpqcorp.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <0F5B06BAB751E047AB5C87D1F77A77884EACB79F52@GVW0547EXC.americas.hpqcorp.net> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1376 Lines: 38 On Thu, Nov 20 2008, Miller, Mike (OS Dev) wrote: > Jens wrote: > > > > > > > I'd propose just converting it to list_head instead of doing it > > > manually. Heck, that should be a 5 minute job, let me just do it... > > > > > > OK, here it is, totally untested (it compiles, must be golden...) > > > > It was missing a list_entry() in fail_all_cmds(), apart from > > that it was fine. I changed it to use hlist instead, as that > > is more appropriate and similar to how it worked before. It > > also means there's no extra space usage in the controller > > structure. I've tested it and it works fine for me. > > > > Mike, can you give this a look-over and give me a Reviewed-by > > or similar? As an extra bonus, it also gets rid of some code. > > > > 3 files changed, 33 insertions(+), 46 deletions(-) > > > > http://git.kernel.dk/?p=linux-2.6-block.git;a=commit;h=e303054 > > e55acd1b6478b8859a5f8648bfaf69a44 > > That works for me. :) > > Acked-by: Mike Miller Excellent, thanks Mike. If you could run it through a cycle or so of your regular testing, I'd feel 100% confident in it. -- Jens Axboe -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/