Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756912AbYKTRw7 (ORCPT ); Thu, 20 Nov 2008 12:52:59 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753471AbYKTRwq (ORCPT ); Thu, 20 Nov 2008 12:52:46 -0500 Received: from pasmtpa.tele.dk ([80.160.77.114]:41433 "EHLO pasmtpA.tele.dk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754891AbYKTRwp (ORCPT ); Thu, 20 Nov 2008 12:52:45 -0500 Date: Thu, 20 Nov 2008 18:50:53 +0100 From: Jens Axboe To: Alan Stern Cc: FUJITA Tomonori , bigeasy@linutronix.de, Thomas.Hommel@gefanuc.com, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, James.Bottomley@HansenPartnership.com Subject: Re: ISP1760 driver crashes Message-ID: <20081120175053.GN26308@kernel.dk> References: <20081120144125P.fujita.tomonori@lab.ntt.co.jp> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2008 Lines: 51 On Thu, Nov 20 2008, Alan Stern wrote: > On Thu, 20 Nov 2008, FUJITA Tomonori wrote: > > > We have been used 4GB for long time if dma_mask is zero (I guess we > > use 4GB as kinda the default dma address limit at several places). The > > majority of drivers (such as pci) sets properly dev->dma_mask so the > > patch might not change anything but suddenly changing the > > long-standing rule in an odd way (use BLK_BOUNCE_HIGH if dma_mask is > > zero) doesn't sound a good idea to me. > > > > Why not calling blk_queue_bounce_limit() in the slave_configure hook? > > I think that it's the common way for SCSI LLDs with odd bounce limit. > > Thomas, here's a patch to do what Tomonori suggests. Try replacing the > old patch with this one. > > Alan Stern > > > Index: usb-2.6/drivers/usb/storage/scsiglue.c > =================================================================== > --- usb-2.6.orig/drivers/usb/storage/scsiglue.c > +++ usb-2.6/drivers/usb/storage/scsiglue.c > @@ -129,6 +129,14 @@ static int slave_configure(struct scsi_d > max_sectors); > } > > + /* Some USB host controllers can't do DMA; they have to use PIO. > + * They indicate this by setting their dma_mask to NULL. For > + * such controllers we need to make sure the block layer sets > + * up bounce buffers in addressable memory. > + */ > + if (!us->pusb_dev->bus->controller->dma_mask) > + blk_queue_bounce_limit(sdev->request_queue, BLK_BOUNCE_HIGH); > + > /* We can't put these settings in slave_alloc() because that gets > * called before the device type is known. Consequently these > * settings can't be overridden via the scsi devinfo mechanism. */ > That looks like a good fix. You can add my Acked-by: to that, if you wish. -- Jens Axboe -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/