Date: Thu, 20 Nov 2008 20:02:12 +0000
From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: David Daney <ddaney@caviumnetworks.com>
Cc: linux-mips@linux-mips.org, linux-serial@vger.kernel.org,
       akpm@linux-foundation.org, linux-kernel@vger.kernel.org,
       David Daney <ddaney@caviumnetworks.com>,
       Tomaso Paoletti <tpaoletti@caviumnetworks.com>
Subject: Re: [PATCH 20/26] 8250: Serial driver changes to support future
 Cavium OCTEON serial patches.
Message-ID: <20081120200212.17e67add@lxorguk.ukuu.org.uk>
In-Reply-To: <1227047057-4911-2-git-send-email-ddaney@caviumnetworks.com>
References: <49233FDE.3010404@caviumnetworks.com>
	<1227047057-4911-2-git-send-email-ddaney@caviumnetworks.com>
Organization: Red Hat UK Cyf., Amberley Place, 107-111 Peascod Street,
 Windsor, Berkshire, SL4 1TE, Y Deyrnas Gyfunol. Cofrestrwyd yng Nghymru a
 Lloegr o'r rhif cofrestru 3798903
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 928
Lines: 22

On Tue, 18 Nov 2008 14:24:14 -0800
David Daney <ddaney@caviumnetworks.com> wrote:

> In order to use Cavium OCTEON specific serial i/o drivers, we first
> patch the 8250 driver to use replaceable I/O functions.  Compatible
> I/O functions are added for existing iotypeS.
> 
> An added benefit of this change is that it makes it easy to factor
> some of the existing special cases out to board/SOC specific support
> code.
> 
> The alternative is to load up 8250.c with a bunch of OCTEON specific
> iotype code and bug work-arounds.

Neither are pretty but this looks the better option I agree. Only niggle
is the use of "_fn" - Linux generally doesn't put types into variable
names.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/