Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756761AbYKTUZH (ORCPT ); Thu, 20 Nov 2008 15:25:07 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754680AbYKTUYz (ORCPT ); Thu, 20 Nov 2008 15:24:55 -0500 Received: from mailrelay005.isp.belgacom.be ([195.238.6.171]:48641 "EHLO mailrelay005.isp.belgacom.be" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753756AbYKTUYy (ORCPT ); Thu, 20 Nov 2008 15:24:54 -0500 X-Belgacom-Dynamic: yes X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AqQEAMhUJUlR93TW/2dsb2JhbACBbc98gnw Date: Thu, 20 Nov 2008 21:24:51 +0100 From: Wim Van Sebroeck To: "Mingarelli, Thomas" Cc: Bernhard Walle , Andrew Morton , "linux-kernel@vger.kernel.org" , "stable@kernel.org" Subject: Re: [PATCH] [WATCHDOG] [hpwdt] Set the mapped BIOS address space as executable Message-ID: <20081120202451.GH30873@infomag.infomag.iguana.be> References: <1226674023-5374-1-git-send-email-bwalle@suse.de> <20081118143015.72af31d3.akpm@linux-foundation.org> <20081118233229.294270fb@kopernikus.site> <183C1D5A376DE343AA8F94FC2A1EC1493AA5CEE7AB@GVW1091EXB.americas.hpqcorp.net> <20081119093041.1af8fd7e.akpm@linux-foundation.org> <20081119183444.56b342cb@hale.suse.de> <20081119230014.GC30873@infomag.infomag.iguana.be> <20081120000215.45071a50@kopernikus.site> <20081119231124.GD30873@infomag.infomag.iguana.be> <183C1D5A376DE343AA8F94FC2A1EC1493AA5D6987F@GVW1091EXB.americas.hpqcorp.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <183C1D5A376DE343AA8F94FC2A1EC1493AA5D6987F@GVW1091EXB.americas.hpqcorp.net> User-Agent: Mutt/1.4.2.1i Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2560 Lines: 65 Hi All, > I tested changing the return value to NOTIFY_OK always. Splendid. I changed the patch (see below). Can you check if all is ok now, so that I can sent them off for mainline inclusion? Kind regards, Wim. ----------------------------------------------------------------------------------------- commit 1adecc3d59d01ac7ffe9ab695cbd7311ab50198e Author: Bernhard Walle Date: Sun Oct 26 15:59:37 2008 +0100 [WATCHDOG] hpwdt: Fix kdump when using hpwdt When the "hpwdt" module is loaded (even if the /dev/watchdog device is not opened), then kdump does not work. The panic kernel either does not start at all or crash in various places. The problem is that hpwdt_pretimeout is registered with register_die_notifier() with the highest possible priority. Because it returns NOTIFY_STOP, the crash_nmi_callback which is also registered with register_die_notifier() is never executed. This causes the shutdown of other CPUs to fail. Reverting the order is no option: The crash_nmi_callback executes HLT and so never returns normally. Because of that, it must be executed as last notifier, which currently is done. So, this patch returns NOTIFY_OK instead of NOTIFY_STOP. Also, it changes the default of allow_kdump to 1. Kdump is quite common and should be working as default. Signed-off-by: Bernhard Walle Signed-off-by: Wim Van Sebroeck Signed-off-by: Thomas Mingarelli Cc: Vivek Goyal diff --git a/drivers/watchdog/hpwdt.c b/drivers/watchdog/hpwdt.c index f6cff7b..8900989 100644 --- a/drivers/watchdog/hpwdt.c +++ b/drivers/watchdog/hpwdt.c @@ -117,7 +117,7 @@ static unsigned int reload; /* the computed soft_margin */ static int nowayout = WATCHDOG_NOWAYOUT; static char expect_release; static unsigned long hpwdt_is_open; -static unsigned int allow_kdump; +static unsigned int allow_kdump = 1; static void __iomem *pci_mem_addr; /* the PCI-memory address */ static unsigned long __iomem *hpwdt_timer_reg; @@ -485,7 +485,7 @@ static int hpwdt_pretimeout(struct notifier_block *nb, unsigned long ulReason, "Management Log for details.\n"); } - return NOTIFY_STOP; + return NOTIFY_OK; } /* -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/