Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753851AbYKUHni (ORCPT ); Fri, 21 Nov 2008 02:43:38 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752152AbYKUHn2 (ORCPT ); Fri, 21 Nov 2008 02:43:28 -0500 Received: from mx2.suse.de ([195.135.220.15]:35190 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751971AbYKUHn1 (ORCPT ); Fri, 21 Nov 2008 02:43:27 -0500 Date: Fri, 21 Nov 2008 08:43:26 +0100 Message-ID: From: Takashi Iwai To: "Hannes Eder" Cc: "Jaroslav Kysela" , linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH] sound/sound_core: Fix sparse warnings: returning void-valued expression and make 'soundcore_open' static In-Reply-To: <154e089b0811201225n78a9f746oc7632e496c445d95@mail.gmail.com> References: <154e089b0811201225n78a9f746oc7632e496c445d95@mail.gmail.com> User-Agent: Wanderlust/2.12.0 (Your Wildest Dreams) SEMI/1.14.6 (Maruoka) FLIM/1.14.7 (=?ISO-8859-4?Q?Sanj=F2?=) APEL/10.6 Emacs/22.3 (x86_64-suse-linux-gnu) MULE/5.0 (SAKAKI) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1662 Lines: 59 At Thu, 20 Nov 2008 21:25:25 +0100, Hannes Eder wrote: > > Fix the following sparse warnings: > > sound/sound_core.c:460:2: warning: returning void-valued expression > sound/sound_core.c:477:2: warning: returning void-valued expression > sound/sound_core.c:510:5: warning: symbol 'soundcore_open' was not > declared. Should it be static? > > Signed-off-by: Hannes Eder Thanks, applied now. Takashi > --- > sound/sound_core.c | 6 +++--- > 1 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/sound/sound_core.c b/sound/sound_core.c > index a75b289..10ba421 100644 > --- a/sound/sound_core.c > +++ b/sound/sound_core.c > @@ -457,7 +457,7 @@ EXPORT_SYMBOL(unregister_sound_mixer); > > void unregister_sound_midi(int unit) > { > - return sound_remove_unit(&chains[2], unit); > + sound_remove_unit(&chains[2], unit); > } > > EXPORT_SYMBOL(unregister_sound_midi); > @@ -474,7 +474,7 @@ EXPORT_SYMBOL(unregister_sound_midi); > > void unregister_sound_dsp(int unit) > { > - return sound_remove_unit(&chains[3], unit); > + sound_remove_unit(&chains[3], unit); > } > > > @@ -507,7 +507,7 @@ static struct sound_unit *__look_for_unit(int > chain, int unit) > return NULL; > } > > -int soundcore_open(struct inode *inode, struct file *file) > +static int soundcore_open(struct inode *inode, struct file *file) > { > int chain; > int unit = iminor(inode); > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/