Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753225AbYKUIaN (ORCPT ); Fri, 21 Nov 2008 03:30:13 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1756401AbYKUI31 (ORCPT ); Fri, 21 Nov 2008 03:29:27 -0500 Received: from E23SMTP02.au.ibm.com ([202.81.18.163]:56613 "EHLO e23smtp02.au.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756357AbYKUI30 (ORCPT ); Fri, 21 Nov 2008 03:29:26 -0500 From: Vaidyanathan Srinivasan Subject: [RFC PATCH v4 0/7] Tunable sched_mc_power_savings=n To: Linux Kernel , Suresh B Siddha , Venkatesh Pallipadi , Peter Zijlstra Cc: Ingo Molnar , Dipankar Sarma , Balbir Singh , Vatsa , Gautham R Shenoy , Andi Kleen , David Collier-Brown , Tim Connors , Max Krasnyansky , Gregory Haskins , Vaidyanathan Srinivasan Date: Fri, 21 Nov 2008 14:00:39 +0530 Message-ID: <20081121082533.27075.12056.stgit@drishya.in.ibm.com> User-Agent: StGIT/0.14.2 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 4613 Lines: 121 Hi, The existing power saving loadbalancer CONFIG_SCHED_MC attempts to run the workload in the system on minimum number of CPU packages and tries to keep rest of the CPU packages idle for longer duration. Thus consolidating workloads to fewer packages help other packages to be in idle state and save power. The current implementation is very conservative and does not work effectively across different workloads. Initial idea of tunable sched_mc_power_savings=n was proposed to enable tuning of the power saving load balancer based on the system configuration, workload characteristics and end user requirements. The power savings and performance of the given workload in an under utilised system can be controlled by setting values of 0, 1 or 2 to /sys/devices/system/cpu/sched_mc_power_savings with 0 being highest performance and least power savings and level 2 indicating maximum power savings even at the cost of slight performance degradation. Please refer to the following discussions and article for details. [1]Making power policy just work http://lwn.net/Articles/287924/ [2][RFC v1] Tunable sched_mc_power_savings=n http://lwn.net/Articles/287882/ [3][RFC PATCH v2 0/7] Tunable sched_mc_power_savings=n http://lwn.net/Articles/297306/ [4][RFC PATCH v3 0/5] Tunable sched_mc_power_savings=n http://lkml.org/lkml/2008/11/10/260 The following series of patch demonstrates the basic framework for tunable sched_mc_power_savings. This version of the patch incorporates comments and feedback received on the previous post. Thanks to Peter Zijlstra, Gregory Haskins, and Vatsa for the review and comments. Changes from v3: ---------------- * Fixed the locking code with double_lock_balance() in active-balance-newidle.patch * Moved sched_mc_preferred_wakeup_cpu to root_domain structure so that each partitioned sched domain will get independent nominated cpu * More comments in active-balance-newidle.patch * Reverted sched MC level and CPU level fine tuning in v2.6.28-rc4 for now. These affect consolidation since SD_BALANCE_NEWIDLE is removed. I will rework the tuning in the next iteration to selectively enable them at sched_mc=2 * Patch series on 2.6.28-rc6 kernel Changes from v2: ---------------- * Fixed locking order issue in active-balance new-idle * Moved the wakeup biasing code to wake_idle() function and preserve wake_affine function. Previous version would break wake affine in order to aggressively consolidate tasks * Removed sched_mc_preferred_wakeup_cpu global variable and moved to doms_cur/dattr_cur and added a per_cpu pointer to appropriate storage in partitioned sched domain. This changed is needed to preserve functionality in case of partitioned sched domains * Patch on 2.6.28-rc3 kernel Results: -------- Basic functionality of the code has not changed and the power vs performance benefits for kernbench are similar to the ones posted earlier. KERNBENCH Runs: make -j4 on a x86 8 core, dual socket quad core cpu package system SchedMC Run Time Package Idle Energy Power 0 80.04 52.77% 53.23% 1.00x J 1.00y W 1 81.41 37.03% 69.67% 0.97x J 0.95y W 2 76.25 20.26% 85.86% 0.92x J 0.97y W *** This is RFC code and not for inclusion *** Please feel free to test, and let me know your comments and feedback. Thanks, Vaidy Signed-off-by: Vaidyanathan Srinivasan --- Gautham R Shenoy (1): sched: Framework for sched_mc/smt_power_savings=N Vaidyanathan Srinivasan (6): sched: fine-tune SD_MC_INIT -- revert sched: re-tune balancing -- revert sched: activate active load balancing in new idle cpus sched: bias task wakeups to preferred semi-idle packages sched: nominate preferred wakeup cpu sched: favour lower logical cpu number for sched_mc balance arch/x86/include/asm/topology.h | 7 +-- include/linux/sched.h | 11 +++++ include/linux/topology.h | 6 +-- kernel/sched.c | 89 +++++++++++++++++++++++++++++++++++++-- kernel/sched_fair.c | 17 +++++++ 5 files changed, 118 insertions(+), 12 deletions(-) -- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/