Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754897AbYKUOau (ORCPT ); Fri, 21 Nov 2008 09:30:50 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753058AbYKUOak (ORCPT ); Fri, 21 Nov 2008 09:30:40 -0500 Received: from rv-out-0506.google.com ([209.85.198.224]:51025 "EHLO rv-out-0506.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753041AbYKUOaj (ORCPT ); Fri, 21 Nov 2008 09:30:39 -0500 Message-ID: Date: Fri, 21 Nov 2008 09:30:38 -0500 From: "Robert Love" To: "Evgeniy Polyakov" Subject: Re: [take 3] Use pid in inotify events. Cc: "Pavel Machek" , mtk.manpages@gmail.com, linux-api@vger.kernel.org, linux-kernel@vger.kernel.org, "Andrew Morton" , "Christoph Hellwig" In-Reply-To: <20081121140325.GA12384@ioremap.net> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <20081116232450.GA13547@ioremap.net> <20081117171508.GA564@ioremap.net> <20081117175212.GA2224@ioremap.net> <20081120130902.GA1408@ucw.cz> <20081121140325.GA12384@ioremap.net> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1390 Lines: 32 On Fri, Nov 21, 2008 at 9:03 AM, Evgeniy Polyakov wrote: > Critics without suggestions is useless. What did you try to say here? > You you believe it should be done in a different way, please tell us how > you see this should be implemented. Pavel has the bedside manner of a T-Rex, but he is right. Your solution needs to be (a) generally applicable and useful, with an (b) elegant and clean API, which (c) does not break ABI or API. Overloading the cookie field is not the way to go. Finding ways to extend the API through inotify_init might be--you will have even higher hurdles of "do we really need this" though. John & I intentionally did not add the pid field when writing inotify for reasons of security and questionable need. It also stinks to have to add a pid field to the event structure if that field is seldom used. Working on lkml often sounds like everyone is screaming NO, channeling nothing but stop energy. Sometimes people are, but more often what they really mean is you just have to take your time and do things right. Admittedly it is a lot of iteration, but Linux is a noble pursuit. Robert -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/