Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755881AbYKUQHD (ORCPT ); Fri, 21 Nov 2008 11:07:03 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752429AbYKUQGy (ORCPT ); Fri, 21 Nov 2008 11:06:54 -0500 Received: from mx3.mail.elte.hu ([157.181.1.138]:37169 "EHLO mx3.mail.elte.hu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752059AbYKUQGx (ORCPT ); Fri, 21 Nov 2008 11:06:53 -0500 Date: Fri, 21 Nov 2008 17:06:29 +0100 From: Ingo Molnar To: Alexander van Heukelum Cc: LKML , Andi Kleen , "H. Peter Anvin" , Jan Beulich , Glauber Costa , Matt Mackall , Thomas Gleixner , Nick Piggin , Cyrill Gorcunov Subject: Re: [PATCH] Split out some macro's and move common code to paranoid_exit Message-ID: <20081121160629.GA24839@elte.hu> References: <1226845741-12470-2-git-send-email-heukelum@fastmail.fm> <20081117175232.GA13766@mailshack.com> <20081119001811.GA23237@mailshack.com> <20081120134011.GA3627@mailshack.com> <20081120150412.GC13550@elte.hu> <20081120152601.GA3953@mailshack.com> <20081120153954.GA22511@elte.hu> <20081121154155.GA12999@mailshack.com> <20081121154318.GA13014@mailshack.com> <20081121154428.GB13014@mailshack.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20081121154428.GB13014@mailshack.com> User-Agent: Mutt/1.5.18 (2008-05-17) X-ELTE-VirusStatus: clean X-ELTE-SpamScore: -1.5 X-ELTE-SpamLevel: X-ELTE-SpamCheck: no X-ELTE-SpamVersion: ELTE 2.0 X-ELTE-SpamCheck-Details: score=-1.5 required=5.9 tests=BAYES_00 autolearn=no SpamAssassin version=3.2.3 -1.5 BAYES_00 BODY: Bayesian spam probability is 0 to 1% [score: 0.0000] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 865 Lines: 32 * Alexander van Heukelum wrote: > /* runs on exception stack */ > ENTRY(stack_segment) > - XCPT_FRAME > - PARAVIRT_ADJUST_EXCEPTION_FRAME > - paranoidentry do_stack_segment > - jmp paranoid_exit > - CFI_ENDPROC > + paranoiderrorentry do_stack_segment > END(stack_segment) cool! Could you please also collapse it into just a single macro? The ENTRY/END sequence can be generated by the macro. (if you do it then please do it in a followup patch, i'll look at and apply your current series) Something like: PARANOID_ERROR_ENTRY(stack_segment) Could do all the magic, right? Ingo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/