Return-Path: <linux-kernel-owner+w=401wt.eu-S1757001AbYKUQlT@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1757001AbYKUQlT (ORCPT <rfc822;w@1wt.eu>);
	Fri, 21 Nov 2008 11:41:19 -0500
Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754433AbYKUQlF
	(ORCPT <rfc822;linux-kernel-outgoing>);
	Fri, 21 Nov 2008 11:41:05 -0500
Received: from outbound-wa4.frontbridge.com ([216.32.181.16]:25543 "EHLO
	WA4EHSOBE002.bigfish.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1752692AbYKUQlB (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Fri, 21 Nov 2008 11:41:01 -0500
X-BigFish: VPS-29(zz1432R98dR1805M936fOzzzzz32i6bh43j62h)
X-Spam-TCS-SCL: 1:0
X-FB-SS: 5,
X-WSS-ID: 0KAOZNR-03-SYW-01
Date: Fri, 21 Nov 2008 17:40:41 +0100
From: Joerg Roedel <joerg.roedel@amd.com>
To: Ingo Molnar <mingo@elte.hu>
CC: Ingo Molnar <mingo@redhat.com>, Thomas Gleixner <tglx@linutronix.de>,
       linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
       iommu@lists.linux-foundation.org
Subject: Re: [PATCH 0/10] DMA-API debugging facility
Message-ID: <20081121164041.GA1386@amd.com>
References: <1227284770-19215-1-git-send-email-joerg.roedel@amd.com> <20081121163717.GA733@elte.hu>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20081121163717.GA733@elte.hu>
User-Agent: mutt-ng/devel-r804 (Linux)
X-OriginalArrivalTime: 21 Nov 2008 16:40:41.0356 (UTC) FILETIME=[E4275CC0:01C94BF7]
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 2301
Lines: 55

On Fri, Nov 21, 2008 at 05:37:17PM +0100, Ingo Molnar wrote:
> 
> * Joerg Roedel <joerg.roedel@amd.com> wrote:
> 
> > Hi,
> > 
> > this patchset introduces code to debug drivers usage of the DMA-API. 
> > Tests with hardware IOMMUs have shown several bugs in drivers 
> > regarding the usage of that API. Problems were found especially in 
> > network card drivers.
> > 
> > These bugs often don't show up or have any negative impact if there 
> > is no hardware IOMMU in use in the system. But with an hardware 
> > IOMMU these bugs turn the hardware unusable or, in the worst case, 
> > cause data corruption on devices which are managed by other (good) 
> > drivers.
> > 
> > With the code these patches introduce driver developers can find 
> > several bugs of misusing the DMA-API in their drivers. But be aware, 
> > it can not find all possible bugs. If it finds a problem it prints 
> > out messages like
> > 
> > tg3 0000:08:04.0: PCI-DMA: device driver tries to free DMA memory it 
> > has not allocated [device address=0x000000042f0f3ae7] [size=48 
> > bytes]
> >
> > Pid: 6285, comm: bash Not tainted 2.6.28-rc5-00176-g6ae6379-dirty #6
> > Call Trace:
> >  <IRQ>  [<ffffffff80221276>] check_unmap+0x52/0x1ce
> >  [<ffffffff80221af0>] debug_unmap_single+0x61/0xa4
> >  [<ffffffff8053d396>] skb_dma_unmap+0xf2/0x10c
> >  [<ffffffff8040a986>] tg3_poll+0xe8/0x822
> >  [<ffffffff803abe2f>] mix_pool_bytes_extract+0x5c/0x155
> >  [<ffffffff80540e42>] net_rx_action+0x9d/0x170
> 
> very nice! I like this approach - and have a few comments on some 
> details - will post them as a reply to the patchs.

Cool. Thank you.

Joerg

-- 
           |           AMD Saxony Limited Liability Company & Co. KG
 Operating |         Wilschdorfer Landstr. 101, 01109 Dresden, Germany
 System    |                  Register Court Dresden: HRA 4896
 Research  |              General Partner authorized to represent:
 Center    |             AMD Saxony LLC (Wilmington, Delaware, US)
           | General Manager of AMD Saxony LLC: Dr. Hans-R. Deppe, Thomas McCoy

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/