Message-ID: <4926EBD8.6070200@kernel.org>
Date: Sat, 22 Nov 2008 02:11:52 +0900
From: Tejun Heo <tj@kernel.org>
User-Agent: Thunderbird 2.0.0.17 (X11/20080922)
MIME-Version: 1.0
To: Miklos Szeredi <miklos@szeredi.hu>
CC: torvalds@linux-foundation.org, hch@infradead.org, mingo@elte.hu,
       rminnich@sandia.gov, ericvh@gmail.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH RESEND] poll: allow f_op->poll to sleep, take #2
References: <491BA16C.30606@kernel.org> <alpine.LFD.2.00.0811151208430.3468@nehalem.linux-foundation.org> <49256CCE.9060107@kernel.org> <E1L3Z5h-0008J7-QN@pomaz-ex.szeredi.hu>
In-Reply-To: <E1L3Z5h-0008J7-QN@pomaz-ex.szeredi.hu>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 2040
Lines: 71

Miklos Szeredi wrote:
> On Thu, 20 Nov 2008, Tejun Heo wrote:
> 
> [snip]
> 
>> +int poll_schedule_timeout(struct poll_wqueues *pwq, int state,
>> +			  ktime_t *expires, unsigned long slack)
> 
> The 'state' parameter is unused, and is always called with the
> TASK_INTERRUPTIBLE value.  Shouldn't it be removed?
> 
>> +{
>> +	int rc = -EINTR;
>> +
>> +	set_current_state(TASK_INTERRUPTIBLE);

Aieee... this should have been set_current_state(state).  We can also
remove @state but this being a schedule() function I think it's better
to pass @state explicitly.

>> +	if (!pwq->triggered)
>> +		rc = schedule_hrtimeout_range(expires, slack, HRTIMER_MODE_ABS);
>> +	__set_current_state(TASK_RUNNING);
>> +
>> +	/* clear triggered for the next iteration */
>> +	pwq->triggered = 0;
>> +
>> +	return rc;
>> +}
>> +
>> +EXPORT_SYMBOL(poll_schedule_timeout);
> 
> Checkpatch warning:
> 
> WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable
> #118: FILE: fs/select.c:216:
> +EXPORT_SYMBOL(poll_schedule_timeout);
> 
> [snip]
> 
>> Index: work/include/linux/poll.h
>> ===================================================================
>> --- work.orig/include/linux/poll.h
>> +++ work/include/linux/poll.h
>> @@ -57,6 +57,8 @@ struct poll_table_entry {
>>  struct poll_wqueues {
>>  	poll_table pt;
>>  	struct poll_table_page * table;
>> +	struct task_struct * polling_task;
>> +	int triggered;
> 
> Checkpatch error:
> 
> ERROR: "foo * bar" should be "foo *bar"
> #173: FILE: include/linux/poll.h:60:
> +       struct task_struct * polling_task;

For both, I was trying to stay consistent with the environment.  I
find mixed styles in close proximity much uglier than slightly
different but consistent style.  Eh... Is the consensus checkpatch or
die?

Thanks.

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/