Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757944AbYKURrI (ORCPT ); Fri, 21 Nov 2008 12:47:08 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754845AbYKURqz (ORCPT ); Fri, 21 Nov 2008 12:46:55 -0500 Received: from e33.co.us.ibm.com ([32.97.110.151]:39888 "EHLO e33.co.us.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753039AbYKURqy (ORCPT ); Fri, 21 Nov 2008 12:46:54 -0500 Subject: Re: [PATCH 2/4] integrity: Linux Integrity Module(LIM) From: Dave Hansen To: Mimi Zohar Cc: linux-kernel@vger.kernel.org, Andrew Morton , James Morris , Christoph Hellwig , Al Viro , David Safford , Serge Hallyn , Mimi Zohar In-Reply-To: References: Content-Type: text/plain Date: Fri, 21 Nov 2008 09:46:43 -0800 Message-Id: <1227289603.11607.38.camel@nimitz> Mime-Version: 1.0 X-Mailer: Evolution 2.22.3.1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 594 Lines: 18 On Thu, 2008-11-20 at 11:43 -0500, Mimi Zohar wrote: > > + rcu_read_lock(); > + rc = integrity_find_template(template_name, &template_entry); > + if (rc == 0) > + tget(template_entry); > + rcu_read_unlock(); This little nugget is repeated over and over. How about an integrity_find_get_template()? -- Dave -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/