Date: Fri, 21 Nov 2008 10:31:01 -0800
From: Andrew Morton <akpm@linux-foundation.org>
To: David Howells <dhowells@redhat.com>
Cc: trond.myklebust@fys.uio.no, viro@ZenIV.linux.org.uk, nfsv4@linux-nfs.org,
       linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
       Randy Dunlap <randy.dunlap@oracle.com>
Subject: Re: [PATCH 24/45] CacheFiles: Add a hook to write a single page of
 data to an inode [ver #41]
Message-Id: <20081121103101.877506e3.akpm@linux-foundation.org>
In-Reply-To: <3843.1227271421@redhat.com>
References: <20081121002317.69e4fd11.akpm@linux-foundation.org>
	<20081120144139.10667.75519.stgit@warthog.procyon.org.uk>
	<20081120144343.10667.530.stgit@warthog.procyon.org.uk>
	<3843.1227271421@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 967
Lines: 26

On Fri, 21 Nov 2008 12:43:41 +0000 David Howells <dhowells@redhat.com> wrote:

> > > +/**
> > > + * generic_file_buffered_write_one_page - Write a single page of data to an
> > > + *	inode
> > 
> > kerneldoc doesn't permit line breaks in this context (unless it got
> > fixed recently)
> 
> So you advocate a line exceeding 80 chars?

yup

> I contend that kerneldoc is a bad idea in many ways: it encourages people to
> be lazy and to not write proper interface documentation.

yes, for some reason kereldoc-formatted comments usually aren't very
useful.  They very often just don't convey useful insights.  I wonder
why.  Maybe people think that once they've filled out the form and
ticked all the boxes, they're done.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/