Date: Fri, 21 Nov 2008 16:43:40 -0800 (PST)
Message-Id: <20081121.164340.67054948.davem@davemloft.net>
To: ptesarik@suse.cz
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
       ilpo.jarvinen@helsinki.fi, jsembera@suse.cz
Subject: Re: [PATCH] Do not use TSO/GSO when there is urgent data
From: David Miller <davem@davemloft.net>
In-Reply-To: <200811211319.45515.ptesarik@suse.cz>
References: <200811211319.45515.ptesarik@suse.cz>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1884
Lines: 50

From: Petr Tesarik <ptesarik@suse.cz>
Date: Fri, 21 Nov 2008 13:19:45 +0100

> This patch fixes http://bugzilla.kernel.org/show_bug.cgi?id=12014
> 
> Since most (if not all) implementations of TSO and even the in-kernel
> software GSO do not update the urgent pointer when splitting a large
> segment, it is necessary to turn off TSO/GSO for all outgoing traffic
> with the URG pointer set.
> 
> Looking at tcp_current_mss (and the preceding comment) I even think
> this was the original intention. However, this approach is insufficient,
> because TSO/GSO is turned off only for newly created frames, not for
> frames which were already pending at the arrival of a message with
> MSG_OOB set. These frames were created when TSO/GSO was enabled,
> so they may be large, and they will have the urgent pointer set
> in tcp_transmit_skb().
> 
> With this patch, such large packets will be fragmented again before
> going to the transmit routine.
> 
> As a side note, at least the following NICs are known to screw up
> the urgent pointer in the TCP header when doing TSO:
> 
> 	Intel 82566MM (PCI ID 8086:1049)
> 	Intel 82566DC (PCI ID 8086:104b)
> 	Intel 82541GI (PCI ID 8086:1076)
> 	Broadcom NetXtreme II BCM5708 (PCI ID 14e4:164c)
> 
> Signed-off-by: Petr Tesarik <ptesarik@suse.cz>

Applied, thanks Petr.

BTW, your email client screwed up the patch by breaking up long lines,
for example:

> @@ -722,7 +722,8 @@ static void tcp_queue_skb(struct sock *sk, struct sk_buff 
> *skb)

And:

> @@ -1163,7 +1164,9 @@ static int tcp_init_tso_segs(struct sock *sk, struct 
> sk_buff *skb,

I fixed it up this time, but I will not in the future.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/