Message-ID: <4927698C.90104@ct.jp.nec.com>
Date: Fri, 21 Nov 2008 18:08:12 -0800
From: Hiroshi Shimamoto <h-shimamoto@ct.jp.nec.com>
User-Agent: Thunderbird 2.0.0.18 (Windows/20081105)
MIME-Version: 1.0
To: "H. Peter Anvin" <hpa@zytor.com>
Cc: Ingo Molnar <mingo@elte.hu>, Thomas Gleixner <tglx@linutronix.de>,
       linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/3] x86: signal: cosmetic unification of sys_rt_sigreturn()
References: <49276229.9060000@ct.jp.nec.com> <492762B1.4020107@ct.jp.nec.com> <4927655B.5070906@zytor.com>
In-Reply-To: <4927655B.5070906@zytor.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 707
Lines: 30

H. Peter Anvin wrote:
> Hiroshi Shimamoto wrote:
>>  
>> +#ifdef CONFIG_X86_32
>>  asmlinkage int sys_rt_sigreturn(unsigned long __unused)
>>  {
>>  	struct pt_regs *regs = (struct pt_regs *)&__unused;
>>  
>>  	return do_rt_sigreturn(regs);
>>  }
> 
> Why not:
> 
> asmlinkage int sys_rt_sigreturn(struct pt_regs regs)
> {
> 	return do_rt_sigreturn(&regs);
> }
> 
> ...?

Good question. I didn't realize about that.
Will take a look.

thanks,
Hiroshi Shimamoto
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/