Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753965AbYKVJsj (ORCPT ); Sat, 22 Nov 2008 04:48:39 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755604AbYKVJsV (ORCPT ); Sat, 22 Nov 2008 04:48:21 -0500 Received: from cantor2.suse.de ([195.135.220.15]:56475 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754410AbYKVJsR (ORCPT ); Sat, 22 Nov 2008 04:48:17 -0500 Date: Sat, 22 Nov 2008 10:48:14 +0100 Message-ID: From: Takashi Iwai To: Randy Dunlap Cc: Stephen Rothwell , linux-next@vger.kernel.org, LKML , Wu Fengguang Subject: Re: [PATCH linux-next] snd-hda: fix build errors In-Reply-To: <49271D1A.8040509@oracle.com> References: <20081121181948.ee771502.sfr@canb.auug.org.au> <492713E8.9080103@oracle.com> <49271D1A.8040509@oracle.com> User-Agent: Wanderlust/2.12.0 (Your Wildest Dreams) SEMI/1.14.6 (Maruoka) FLIM/1.14.7 (=?ISO-8859-4?Q?Sanj=F2?=) APEL/10.6 Emacs/22.3 (x86_64-suse-linux-gnu) MULE/5.0 (SAKAKI) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 3713 Lines: 76 At Fri, 21 Nov 2008 12:42:02 -0800, Randy Dunlap wrote: > > Takashi Iwai wrote: > > At Fri, 21 Nov 2008 12:02:48 -0800, > > Randy Dunlap wrote: > >> From: Randy Dunlap > >> > >> First error comes from snd_hda_eld_proc_new() not being static > >> when CONFIG_PROC_FS=n. After that is fixed, the next problem is: > >> ERROR: "snd_print_pcm_rates" [sound/pci/hda/snd-hda-intel.ko] undefined! > >> > >> so I made a static inline version of that one too, for CONFIG_PROC_FS=n. > >> Please build/test more config variations. > >> > >> LD [M] sound/pci/hda/snd-hda-intel.o > >> sound/pci/hda/hda_eld.o: In function `snd_hda_eld_proc_new': > >> (.text+0x0): multiple definition of `snd_hda_eld_proc_new' > >> sound/pci/hda/hda_codec.o:(.text+0x58): first defined here > >> sound/pci/hda/hda_hwdep.o: In function `snd_hda_eld_proc_new': > >> (.text+0x0): multiple definition of `snd_hda_eld_proc_new' > >> sound/pci/hda/hda_codec.o:(.text+0x58): first defined here > >> sound/pci/hda/hda_generic.o: In function `snd_hda_eld_proc_new': > >> (.text+0x1d): multiple definition of `snd_hda_eld_proc_new' > >> sound/pci/hda/hda_codec.o:(.text+0x58): first defined here > >> sound/pci/hda/patch_realtek.o: In function `snd_hda_eld_proc_new': > >> (.text+0x3b): multiple definition of `snd_hda_eld_proc_new' > >> sound/pci/hda/hda_codec.o:(.text+0x58): first defined here > >> sound/pci/hda/patch_cmedia.o: In function `snd_hda_eld_proc_new': > >> (.text+0x0): multiple definition of `snd_hda_eld_proc_new' > >> sound/pci/hda/hda_codec.o:(.text+0x58): first defined here > >> sound/pci/hda/patch_analog.o: In function `snd_hda_eld_proc_new': > >> (.text+0x0): multiple definition of `snd_hda_eld_proc_new' > >> sound/pci/hda/hda_codec.o:(.text+0x58): first defined here > >> sound/pci/hda/patch_sigmatel.o: In function `snd_hda_eld_proc_new': > >> (.text+0x3b): multiple definition of `snd_hda_eld_proc_new' > >> sound/pci/hda/hda_codec.o:(.text+0x58): first defined here > >> sound/pci/hda/patch_atihdmi.o: In function `snd_hda_eld_proc_new': > >> (.text+0x3b): multiple definition of `snd_hda_eld_proc_new' > >> sound/pci/hda/hda_codec.o:(.text+0x58): first defined here > >> sound/pci/hda/patch_conexant.o: In function `snd_hda_eld_proc_new': > >> (.text+0x0): multiple definition of `snd_hda_eld_proc_new' > >> sound/pci/hda/hda_codec.o:(.text+0x58): first defined here > >> sound/pci/hda/patch_via.o: In function `snd_hda_eld_proc_new': > >> (.text+0x0): multiple definition of `snd_hda_eld_proc_new' > >> sound/pci/hda/hda_codec.o:(.text+0x58): first defined here > >> sound/pci/hda/patch_intelhdmi.o: In function `snd_hda_eld_proc_new': > >> (.text+0x3b): multiple definition of `snd_hda_eld_proc_new' > >> sound/pci/hda/hda_codec.o:(.text+0x58): first defined here > >> make[4]: *** [sound/pci/hda/snd-hda-intel.o] Error 1 > >> > >> Signed-off-by: Randy Dunlap > >> cc: Wu Fengguang > >> cc: Takashi Iwai > >> --- > >> sound/pci/hda/hda_local.h | 7 ++++++- > >> 1 file changed, 6 insertions(+), 1 deletion(-) > > > > Thanks, but these have been differently fixed on the latest ALSA tree. > > snd_print_pcm_*() have to be defined no matter what CONFIG_PROC_FS is. > > No problem. Just for clarification, is linux-next one day behind > your latest tree, or is linux-next using a different branch of it, > or what? The former, just due to the time zone :) thanks, Takashi -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/