Date: Sat, 22 Nov 2008 16:47:38 +0000
From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>, linux-next@vger.kernel.org,
       LKML <linux-kernel@vger.kernel.org>,
       Linux/m68k <linux-m68k@vger.kernel.org>
Subject: Re: vme_scc.c breakage (was: Re: linux-next: Tree for November 21)
Message-ID: <20081122164738.2226b63e@lxorguk.ukuu.org.uk>
In-Reply-To: <Pine.LNX.4.64.0811221558340.30025@anakin>
References: <20081121181948.ee771502.sfr@canb.auug.org.au>
	<Pine.LNX.4.64.0811221558340.30025@anakin>
Organization: Red Hat UK Cyf., Amberley Place, 107-111 Peascod Street,
 Windsor, Berkshire, SL4 1TE, Y Deyrnas Gyfunol. Cofrestrwyd yng Nghymru a
 Lloegr o'r rhif cofrestru 3798903
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1079
Lines: 29

> | -	struct scc_port *port = ptr;
> | +	struct scc_port *scc = container_of(port, struct scc_port, gs.port);
> |  	unsigned channel = port->channel;
> |  
> |  	return !!(scc_last_status_reg[channel] & SR_DCD);
> 
> Issues:
>   1. When Atari support is enabled, `scc' is defined in
>      include/asm-m68k/atari.h as:
> 
> 	# define scc ((*(volatile struct SCC*)SCC_BAS))
> 
>      However, renaming the variable `scc' doesn't help, as
> 
>   2. the variable `scc' is not used in scc_carrier_raised(),
> 
>   3. `port->channel' on line 635 still fails as `port' is not longer `struct
>      scc_port', but a 'struct tty_port', which has no member named 'channel'.

Will take a look at this, but gs is going to away so at some point
someone with hardware is going to have to admit to owning this driver or
just mark it BROKEN..

Alan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/