Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758930AbYKVRbh (ORCPT ); Sat, 22 Nov 2008 12:31:37 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1758680AbYKVRb3 (ORCPT ); Sat, 22 Nov 2008 12:31:29 -0500 Received: from mx2.redhat.com ([66.187.237.31]:50014 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758697AbYKVRb2 (ORCPT ); Sat, 22 Nov 2008 12:31:28 -0500 Date: Sat, 22 Nov 2008 10:29:52 -0700 From: Pete Zaitcev To: Greg KH Cc: Rusty Russell , Stephen Rothwell , linux-kernel@vger.kernel.org, katzj@redhat.com Subject: Re: linux-next: rr tree build failure Message-Id: <20081122102952.50ec43ce.zaitcev@redhat.com> In-Reply-To: <20081122064132.GA6196@suse.de> References: <20081121141913.90d05091.sfr@canb.auug.org.au> <200811212128.52317.rusty@rustcorp.com.au> <20081121183403.GC16353@suse.de> <200811221301.07058.rusty@rustcorp.com.au> <20081122064132.GA6196@suse.de> Organization: Red Hat, Inc. Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1189 Lines: 26 On Fri, 21 Nov 2008 22:41:32 -0800, Greg KH wrote: > > FYI, if Pete had discovered this __setup issue today, the correct fix would > > be: > > 1) core_param(nousb) for backwards compat. > > 2) module_param(disable) for modern users who want module/in-built symmetry > > (ie. boot cmdline "usbcore.disable", and "modprobe usbcore disable") > Is there a real reason why we need to change this at all? As far as I know, in Fedora "nousb" is never used as a module parameter. It came about because interrupt tables are sometimes bad and once a request_irq() is done in an HCD, there's an interrupt storm. So, the "nousb" is mostly used in the SysLinux's command line, rarely in the real command line, and never in /etc/modprobe.conf. I'm adding Jeremy to cc: for confirmation. I think it would be good to try and drop "nousb" option in Fedora 11. The conflict with "nousbstorage" would resolve itself too if we do. -- Pete -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/