Date: Sun, 23 Nov 2008 09:53:10 +0100
From: Ingo Molnar <mingo@elte.hu>
To: =?iso-8859-1?B?VPZy9ms=?= Edwin <edwintorok@gmail.com>
Cc: srostedt@redhat.com, a.p.zijlstra@chello.nl, sandmann@daimi.au.dk,
       linux-kernel@vger.kernel.org, viro@ZenIV.linux.org.uk
Subject: Re: [PATCH 2/2] tracing: identify which executable object the
	userspace address belongs to
Message-ID: <20081123085310.GF30453@elte.hu>
References: <1227353328-16104-1-git-send-email-edwintorok@gmail.com> <1227353328-16104-3-git-send-email-edwintorok@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <1227353328-16104-3-git-send-email-edwintorok@gmail.com>
User-Agent: Mutt/1.5.18 (2008-05-17)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1762
Lines: 60


* T?r?k Edwin <edwintorok@gmail.com> wrote:

> Impact: modify+improve the userstacktrace tracing visualization feature

> +static inline int seq_print_user_ip(struct trace_seq *s, struct mm_struct *mm,
> +				    unsigned long ip, unsigned long sym_flags)
> +{
> +	struct file *file = NULL;
> +	unsigned long vmstart = 0;
> +	int ret = 1;
> +
> +	if (mm) {
> +		const struct vm_area_struct *vma = find_vma(mm, ip);
> +		if (vma) {

Style: please put a newline after variable definition blocks.

> +			file = vma->vm_file;
> +			vmstart = vma->vm_start;

Bug: it's generally unsafe to look up a vma and use it without having 
done a down_read(&mm->mmap_sem). Another thread (of this ->mm) could 
go and modify it in parallel.

> +		}
> +	}
> +	if (file) {
> +		ret = trace_seq_path(s, &file->f_path);
> +		if (ret)
> +			ret = trace_seq_printf(s, "[+0x%lx]",
> +					ip - vmstart);

Style: that linebreak is unnecessary.

> +	if (trace_flags & TRACE_ITER_SYM_USEROBJ) {
> +		struct task_struct *task;
> +		/*
> +		 * we do the lookup on the thread group leader,
> +		 * since individual threads might have already quit!
> +		 */
> +		rcu_read_lock();
> +		task = find_task_by_vpid(entry->ent.tgid);
> +		rcu_read_unlock();
> +
> +		if (task)
> +			mm = get_task_mm(task);

Bug: it is unsafe to look up a task and then drop the RCU lock and use 
it - the task could go away the moment the RCU read-lock is dropped.

A safer sequence would be to get get_task_mm(task) reference inside 
the RCU critical section.

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/