Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758539AbYKWKwe (ORCPT ); Sun, 23 Nov 2008 05:52:34 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1757014AbYKWKwW (ORCPT ); Sun, 23 Nov 2008 05:52:22 -0500 Received: from mx3.mail.elte.hu ([157.181.1.138]:42614 "EHLO mx3.mail.elte.hu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756794AbYKWKwW (ORCPT ); Sun, 23 Nov 2008 05:52:22 -0500 Date: Sun, 23 Nov 2008 11:52:11 +0100 From: Ingo Molnar To: =?iso-8859-1?B?VPZy9ms=?= Edwin Cc: srostedt@redhat.com, a.p.zijlstra@chello.nl, sandmann@daimi.au.dk, linux-kernel@vger.kernel.org, viro@ZenIV.linux.org.uk Subject: Re: [PATCH 2/3] tracing/stack-tracer: fix locking Message-ID: <20081123105211.GC30453@elte.hu> References: <20081123085310.GF30453@elte.hu> <1227436748-17075-2-git-send-email-edwintorok@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1227436748-17075-2-git-send-email-edwintorok@gmail.com> User-Agent: Mutt/1.5.18 (2008-05-17) X-ELTE-VirusStatus: clean X-ELTE-SpamScore: -1.5 X-ELTE-SpamLevel: X-ELTE-SpamCheck: no X-ELTE-SpamVersion: ELTE 2.0 X-ELTE-SpamCheck-Details: score=-1.5 required=5.9 tests=BAYES_00 autolearn=no SpamAssassin version=3.2.3 -1.5 BAYES_00 BODY: Bayesian spam probability is 0 to 1% [score: 0.0000] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 609 Lines: 23 * T?r?k Edwin wrote: > + down_read(&mm->mmap_sem); > + vma = find_vma(mm, ip); > if (vma) { > file = vma->vm_file; > vmstart = vma->vm_start; > } > + up_read(&mm->mmap_sem); > } > if (file) { > ret = trace_seq_path(s, &file->f_path); and now it's "file" that is held without a reference and possibly racy. Ingo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/