Date: Sun, 23 Nov 2008 12:20:43 +0100
From: Ingo Molnar <mingo@elte.hu>
To: =?iso-8859-1?B?VPZy9ms=?= Edwin <edwintorok@gmail.com>
Cc: srostedt@redhat.com, a.p.zijlstra@chello.nl, sandmann@daimi.au.dk,
       linux-kernel@vger.kernel.org, viro@ZenIV.linux.org.uk
Subject: Re: [PATCH] tracing/stack-tracer: avoid races accessing file
Message-ID: <20081123112043.GA29663@elte.hu>
References: <20081123110714.GE30453@elte.hu> <1227438490-23259-1-git-send-email-edwintorok@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <1227438490-23259-1-git-send-email-edwintorok@gmail.com>
User-Agent: Mutt/1.5.18 (2008-05-17)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1092
Lines: 36


* T?r?k Edwin <edwintorok@gmail.com> wrote:

> ---
>  kernel/trace/trace.c |   10 +++++-----
>  1 files changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/kernel/trace/trace.c b/kernel/trace/trace.c
> index 4c3bd82..48d1536 100644
> --- a/kernel/trace/trace.c
> +++ b/kernel/trace/trace.c
> @@ -1470,13 +1470,13 @@ static inline int seq_print_user_ip(struct trace_seq *s, struct mm_struct *mm,
>  			file = vma->vm_file;
>  			vmstart = vma->vm_start;
>  		}
> +		if (file) {
> +			ret = trace_seq_path(s, &file->f_path);
> +			if (ret)
> +				ret = trace_seq_printf(s, "[+0x%lx]", ip - vmstart);
> +		}
>  		up_read(&mm->mmap_sem);
>  	}
> -	if (file) {
> -		ret = trace_seq_path(s, &file->f_path);
> -		if (ret)
> -			ret = trace_seq_printf(s, "[+0x%lx]", ip - vmstart);
> -	}

applied to tip/tracing/stack-tracer, thanks Edwin!

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/