Date: Sun, 23 Nov 2008 12:23:54 +0100
From: Alexander van Heukelum <heukelum@mailshack.com>
To: Cyrill Gorcunov <gorcunov@gmail.com>
Cc: Ingo Molnar <mingo@elte.hu>, LKML <linux-kernel@vger.kernel.org>,
       Andi Kleen <andi@firstfloor.org>, "H. Peter Anvin" <hpa@zytor.com>,
       Jan Beulich <jbeulich@novell.com>, Glauber Costa <gcosta@redhat.com>,
       Matt Mackall <mpm@selenic.com>, Thomas Gleixner <tglx@linutronix.de>,
       Nick Piggin <nickpiggin@yahoo.com.au>
Subject: Re: [PATCH] x86: include ENTRY/END in entry handlers in entry_64.S
Message-ID: <20081123112354.GA31667@mailshack.com>
References: <20081120134011.GA3627@mailshack.com> <20081120150412.GC13550@elte.hu> <20081120152601.GA3953@mailshack.com> <20081120153954.GA22511@elte.hu> <20081121154155.GA12999@mailshack.com> <20081121154318.GA13014@mailshack.com> <20081121154428.GB13014@mailshack.com> <20081121160629.GA24839@elte.hu> <20081123090828.GA31490@mailshack.com> <20081123092136.GC24818@localhost>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20081123092136.GC24818@localhost>
User-Agent: Mutt/1.5.9i
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1415
Lines: 39

On Sun, Nov 23, 2008 at 12:21:36PM +0300, Cyrill Gorcunov wrote:
> [Alexander van Heukelum - Sun, Nov 23, 2008 at 10:08:28AM +0100]
> | Impact: cleanup of entry_64.S
> | 
> | Except for the order and the place of the functions, this
> | patch should not change the generated code.
> | 
> | Signed-off-by: Alexander van Heukelum <heukelum@fastmail.fm>
> | 
> | ---
> |  arch/x86/kernel/entry_64.S |  259 +++++++++++++++++++-------------------------
> |  1 files changed, 109 insertions(+), 150 deletions(-)
> |
> 
> Hi Alexander,
> 
> great! One moment is not obvious for me -- why we
> stopped to align interrupt section to 32 bytes?
> Did I miss anyhing?

I put a ".p2align 5" in earlier in the series which caused the
apicinterrupts to be 32-byte aligned. But it is a hack, really,
relying on the generated code per stub to be between 17 and 32
bytes, on the default alignment to be 16 bytes and all stubs
to be in the .text section.

I'm in favour of aligning all of the interrupt/exception stubs
to 32 bytes, but it should be implemented the right way ;),
which means that we need KPROBE_ENTRY_P5ALIGNED and so on :-/.

Greetings,
        Alexander
 
> 		- Cyrill -
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/