Date: Sun, 23 Nov 2008 19:46:52 +0100
From: Alexander van Heukelum <heukelum@mailshack.com>
To: Cyrill Gorcunov <gorcunov@gmail.com>
Cc: Sam Ravnborg <sam@ravnborg.org>, Ingo Molnar <mingo@elte.hu>,
       "H. Peter Anvin" <hpa@zytor.com>, Thomas Gleixner <tglx@linutronix.de>,
       LKML <linux-kernel@vger.kernel.org>
Subject: Re: [RFC -tip] x86: introduce ENTRY(KPROBE)_X86  assembly helpers to catch unbalanced declaration
Message-ID: <20081123184652.GB419@mailshack.com>
References: <20081123165711.GA12710@localhost> <20081123175125.GA32472@uranus.ravnborg.org> <20081123175846.GF12710@localhost> <20081123181248.GA338@uranus.ravnborg.org> <20081123182103.GH12710@localhost>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20081123182103.GH12710@localhost>
User-Agent: Mutt/1.5.9i
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1553
Lines: 40

On Sun, Nov 23, 2008 at 09:21:03PM +0300, Cyrill Gorcunov wrote:
> [Sam Ravnborg - Sun, Nov 23, 2008 at 07:12:48PM +0100]
> ...
> | > 
> | > I don't have -next tree on my laptop, neither cross-compile tools but
> | > if someone could test it -- it would be great. But I used gas macros
> | > here -- i doubt other architectures has the same syntax. At least
> | > PDP-11 would beat us with ';' symbol :)
> | 
> | If we include this in any of the 100+ trees that Stephen sucks
> | into -next we will get it tried out.
> | 
> | Ingo has so and so does others so getting it into -next
> | is rather easy. Then the automated builds will tell of if
> | it fails on any of the toolchains used there.
> | 
> | 	Sam
> | 
> 
> Sam, to be clear, you mean that I could put this stuff into general
> include/linux/linkage.h with general names as ENTRY/END and the same
> for KPROBE so it could be merged into -next tree for testing? If yes,
> that as I said there will be a lot of errors so build will stuck in
> a moment 'cause of unbalanced ENTRY. Not sure if it's a good idea :)

Hi Cyrill,

Aborting might be a bit to heavyhanded for -next. Maybe you should
prepare a version that only gives a warning for the first problem
it encounters per file? That would be fine in -next.

Greetings,
	Alexander

> 		- Cyrill -
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/