From: Andreas Schwab <schwab@suse.de>
To: Andi Kleen <andi@firstfloor.org>
Cc: Geert Uytterhoeven <geert@linux-m68k.org>,
       =?iso-8859-1?Q?T=F6r=F6k?= Edwin <edwintorok@gmail.com>,
       Ingo Molnar <mingo@elte.hu>, Arjan van de Ven <arjan@linux.intel.com>,
       Thomas Gleixner <tglx@linutronix.de>,
       Steven Rostedt <rostedt@goodmis.org>,
       David Howells <dhowells@redhat.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] __used is needed for function referenced only from inline asm
References: <1227514662-10848-1-git-send-email-edwintorok@gmail.com>
	<Pine.LNX.4.64.0811240948130.30025@anakin>
	<873ahhiil1.fsf@basil.nowhere.org>
Date: Mon, 24 Nov 2008 10:32:54 +0100
In-Reply-To: <873ahhiil1.fsf@basil.nowhere.org> (Andi Kleen's message of "Mon,
	24 Nov 2008 10:22:50 +0100")
Message-ID: <je7i6twjsp.fsf@sykes.suse.de>
User-Agent: Gnus/5.110009 (No Gnus v0.9) Emacs/22.3 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 888
Lines: 27

Andi Kleen <andi@firstfloor.org> writes:

> Geert Uytterhoeven <geert@linux-m68k.org> writes:
>>>   */
>>> -static void noinline __sched
>>> +static __used noinline void __sched
>>
>> Perhaps we should incorporate it into `noinline'?
>
> No, we use noinline for other reasons too. Perhaps the other way
> around though.

Or just drop noinline here (since there are no callers to inline into
anyway).

Andreas.

-- 
Andreas Schwab, SuSE Labs, schwab@suse.de
SuSE Linux Products GmbH, Maxfeldstra?e 5, 90409 N?rnberg, Germany
PGP key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/