Date: Mon, 24 Nov 2008 10:51:51 +0100 (CET)
From: Guennadi Liakhovetski <lg@denx.de>
To: rpurdie@rpsys.net
cc: linux-kernel@vger.kernel.org
Subject: leds/leds-pca9532.c: sleeping function called in .brightness_set()
Message-ID: <Pine.LNX.4.64.0811241041130.4148@axis700.grange>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1056
Lines: 28

Hi,

this seems to explicitly violate the API as documented in 
include/linux/leds.h:

	/* Set LED brightness level */
	/* Must not sleep, use a workqueue if needed */
	void		(*brightness_set)(struct led_classdev *led_cdev,
					  enum led_brightness brightness);

and also contradicts some other drivers, e.g., pca955x, which do use a 
workqueue as suggested: leds-pca9532.c::pca9532_set_brightness uses a 
mutex for locking and calls i2c_smbus functions directly. Needs to be 
fixed (if it hasn't been fixed yet), probably, also vor 2.6.27-stable.

Thanks
Guennadi
---
Guennadi Liakhovetski, Ph.D.

DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office@denx.de
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/