From: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
To: Mathieu Desnoyers <mathieu.desnoyers@polymtl.ca>
Subject: Re: [ltt-dev] [RFC PATCH] Poll : add poll_wait_set_exclusive (fixing thundering	herd problem in LTTng)
Cc: kosaki.motohiro@jp.fujitsu.com, ltt-dev@lists.casi.polymtl.ca,
       Ingo Molnar <mingo@elte.hu>, linux-kernel@vger.kernel.org,
       William Lee Irwin III <wli@holomorphy.com>
In-Reply-To: <20081124112429.GA15791@Krystal>
References: <20081124112429.GA15791@Krystal>
Message-Id: <20081124203932.26BE.KOSAKI.MOTOHIRO@jp.fujitsu.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="US-ASCII"
Content-Transfer-Encoding: 7bit
Date: Mon, 24 Nov 2008 20:44:13 +0900 (JST)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1503
Lines: 50

Hi

>  static struct poll_table_entry *poll_get_entry(poll_table *_p)
>  {
>  	struct poll_wqueues *p = container_of(_p, struct poll_wqueues, pt);
> @@ -117,8 +135,10 @@ static struct poll_table_entry *poll_get
>  }
>  
>  /* Add a new entry */
> -static void __pollwait(struct file *filp, wait_queue_head_t *wait_address,
> -				poll_table *p)
> +static void __pollwait_common(struct file *filp,
> +			      wait_queue_head_t *wait_address,
> +			      poll_table *p,
> +			      int exclusive)
>  {
>  	struct poll_table_entry *entry = poll_get_entry(p);
>  	if (!entry)
> @@ -127,7 +147,23 @@ static void __pollwait(struct file *filp
>  	entry->filp = filp;
>  	entry->wait_address = wait_address;
>  	init_waitqueue_entry(&entry->wait, current);
> -	add_wait_queue(wait_address, &entry->wait);
> +	if (!exclusive)
> +		add_wait_queue(wait_address, &entry->wait);
> +	else
> +		add_wait_queue_exclusive(wait_address, &entry->wait);
> +}


I fully agreed this feature is needed.
Actually, I've made similar patch at one years ago.

http://marc.info/?l=linux-kernel&m=120257050719087&w=2


but, I have one question.
My version have epoll support, but yours donesn't have.
Is it intensionally?

this is just dumb question, it doesn't mean any objection.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/