Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752945AbYKXNYi (ORCPT ); Mon, 24 Nov 2008 08:24:38 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751616AbYKXNY3 (ORCPT ); Mon, 24 Nov 2008 08:24:29 -0500 Received: from ns1.suse.de ([195.135.220.2]:59321 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750703AbYKXNY3 (ORCPT ); Mon, 24 Nov 2008 08:24:29 -0500 Date: Mon, 24 Nov 2008 14:24:27 +0100 Message-ID: From: Takashi Iwai To: "Richard A. Holden III" Cc: linux-next@vger.kernel.org, alsa-devel@alsa-project.org, Mark Brown , linux-kernel@vger.kernel.org, Liam Girdwood Subject: Re: [alsa-devel] [PATCH] Remove unused variable from tlv320aic23 codec In-Reply-To: <1227204203-32112-3-git-send-email-aciddeath@gmail.com> References: <1227204203-32112-1-git-send-email-aciddeath@gmail.com> <1227204203-32112-2-git-send-email-aciddeath@gmail.com> <1227204203-32112-3-git-send-email-aciddeath@gmail.com> User-Agent: Wanderlust/2.12.0 (Your Wildest Dreams) SEMI/1.14.6 (Maruoka) FLIM/1.14.7 (=?ISO-8859-4?Q?Sanj=F2?=) APEL/10.6 Emacs/22.3 (x86_64-suse-linux-gnu) MULE/5.0 (SAKAKI) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1557 Lines: 48 At Thu, 20 Nov 2008 11:03:23 -0700, Richard A. Holden III wrote: > > Remove codec var from tlv320aic23_set_dai_sysclk, it is assigned to > but never read. > > Signed-off-by: Richard A. Holden III > > Cc: Jaroslav Kysela > Cc: Takashi Iwai > Cc: Liam Girdwood > Cc: Mark Brown > Cc: alsa-devel@alsa-project.org > --- > sound/soc/codecs/tlv320aic23.c | 2 -- > 1 files changed, 0 insertions(+), 2 deletions(-) This is already fixed in the upstream, but pretty differently. Takashi > diff --git a/sound/soc/codecs/tlv320aic23.c b/sound/soc/codecs/tlv320aic23.c > index 44308da..45395d0 100644 > --- a/sound/soc/codecs/tlv320aic23.c > +++ b/sound/soc/codecs/tlv320aic23.c > @@ -421,8 +421,6 @@ static int tlv320aic23_set_dai_fmt(struct snd_soc_dai *codec_dai, > static int tlv320aic23_set_dai_sysclk(struct snd_soc_dai *codec_dai, > int clk_id, unsigned int freq, int dir) > { > - struct snd_soc_codec *codec = codec_dai->codec; > - > switch (freq) { > case 12000000: > return 0; > -- > 1.5.6.4 > > _______________________________________________ > Alsa-devel mailing list > Alsa-devel@alsa-project.org > http://mailman.alsa-project.org/mailman/listinfo/alsa-devel > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/