Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754045AbYKXP5R (ORCPT ); Mon, 24 Nov 2008 10:57:17 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753248AbYKXP44 (ORCPT ); Mon, 24 Nov 2008 10:56:56 -0500 Received: from mtagate1.de.ibm.com ([195.212.17.161]:41279 "EHLO mtagate1.de.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752945AbYKXP4z (ORCPT ); Mon, 24 Nov 2008 10:56:55 -0500 Message-ID: <492ACEC4.3020702@de.ibm.com> Date: Mon, 24 Nov 2008 16:56:52 +0100 From: Jan-Bernd Themann User-Agent: Thunderbird 2.0.0.16 (X11/20080715) MIME-Version: 1.0 To: netdev@vger.kernel.org CC: linux-kernel@vger.kernel.org, tklein@de.ibm.com, Christoph Raisch , jb.billaud@gmail.com, hering2@de.ibm.com Subject: [RFC PATCH] lro: ip fragment checking Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1176 Lines: 44 Currently there is no checking in the LRO receive path whether TCP packets are ip fragmented. We should not consider those packets for aggregation. I'm not sure if this checking is actually required. Does anyone know if it is possible to get fragmented TCP packets without the tcp stack changing the MSS size? This patch introduces explicit checking. Any objections? Regards, Jan-Bernd --- net/ipv4/inet_lro.c | 3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/net/ipv4/inet_lro.c b/net/ipv4/inet_lro.c index cfd034a..1f9159d 100644 --- a/net/ipv4/inet_lro.c +++ b/net/ipv4/inet_lro.c @@ -64,6 +64,9 @@ static int lro_tcp_ip_check(struct iphdr *iph, struct tcphdr *tcph, if (iph->ihl != IPH_LEN_WO_OPTIONS) return -1; + if (iph->frag_off & IP_MF) + return -1; + if (tcph->cwr || tcph->ece || tcph->urg || !tcph->ack || tcph->rst || tcph->syn || tcph->fin) return -1; -- 1.5.5 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/