Return-Path: <linux-kernel-owner+w=401wt.eu-S1754042AbYKXRK1@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1754042AbYKXRK1 (ORCPT <rfc822;w@1wt.eu>);
	Mon, 24 Nov 2008 12:10:27 -0500
Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752734AbYKXRKS
	(ORCPT <rfc822;linux-kernel-outgoing>);
	Mon, 24 Nov 2008 12:10:18 -0500
Received: from rcsinet11.oracle.com ([148.87.113.123]:26576 "EHLO
	rgminet11.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1752473AbYKXRKQ (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Mon, 24 Nov 2008 12:10:16 -0500
Message-ID: <492ADFC4.1090506@oracle.com>
Date: Mon, 24 Nov 2008 09:09:24 -0800
From: Randy Dunlap <randy.dunlap@oracle.com>
Organization: Oracle Linux Engineering
User-Agent: Thunderbird 2.0.0.6 (X11/20070801)
MIME-Version: 1.0
To: coyli@suse.de
CC: linux-kernel@vger.kernel.org, Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH] fix similar typos to successfull
References: <492A9EFF.5050301@suse.de> <492AD564.9040300@oracle.com> <492AE09A.7070204@suse.de>
In-Reply-To: <492AE09A.7070204@suse.de>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
X-Source-IP: acsmt705.oracle.com [141.146.40.83]
X-Auth-Type: Internal IP
X-CT-RefId: str=0001.0A090205.492ADFC7.0124:SCFSTAT928724,ss=1,fgs=0
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 2825
Lines: 74

Coly Li wrote:
> 
> Randy Dunlap Wrote:
>> Coly Li wrote:
>>> When I review ocfs2 code, find there are 2 typos to "successfull". After doing grep "successfull "
>>> in kernel tree, 22 typos found totally --  great minds always think alike :)
>>>
>>> This patch fixes all the similar typos.
>>>
>>> Singed-off-by: Coly Li <coyli@suse.de>
>>> ---
>>>  Documentation/hwmon/abituguru-datasheet   |    4 ++--
>>>  Documentation/scsi/scsi_fc_transport.txt  |    4 ++--
>>>  arch/powerpc/platforms/cell/spufs/spufs.h |    2 +-
>>>  drivers/infiniband/hw/nes/nes_cm.c        |    2 +-
>>>  drivers/isdn/hardware/eicon/debuglib.h    |    2 +-
>>>  drivers/isdn/hardware/eicon/os_4bri.c     |    2 +-
>>>  drivers/isdn/hardware/eicon/os_bri.c      |    2 +-
>>>  drivers/isdn/hardware/eicon/os_pri.c      |    2 +-
>>>  drivers/mtd/ubi/kapi.c                    |    2 +-
>>>  drivers/net/wireless/ath5k/dma.c          |    2 +-
>>>  drivers/net/wireless/zd1211rw/zd_mac.c    |    2 +-
>>>  drivers/s390/block/dasd_3990_erp.c        |    2 +-
>>>  drivers/s390/block/dasd_int.h             |    2 +-
>>>  drivers/s390/char/tape_3590.c             |    2 +-
>>>  drivers/s390/cio/cio.c                    |    2 +-
>>>  drivers/s390/cio/qdio_main.c              |    2 +-
>>>  fs/ext4/extents.c                         |    2 +-
>>>  fs/ocfs2/dlmglue.c                        |    4 ++--
>>>  net/sctp/auth.c                           |    2 +-
>>>  19 files changed, 22 insertions(+), 22 deletions(-)
>> Ack all <deleted> patches.  However, I don't think that the
>> one below needs to use -ly.  Just change to "successful" IMO,
>> as in:  Log this successful return from ocfs2_dlm_lock
>>
> So "return" here is noun, not verb ?

Yes.

> Thanks for ack :)
>> Thanks.
>>
>>> diff --git a/fs/ocfs2/dlmglue.c b/fs/ocfs2/dlmglue.c
>>> index ec68442..d0cd0e1 100644
>>> --- a/fs/ocfs2/dlmglue.c
>>> +++ b/fs/ocfs2/dlmglue.c
>>> @@ -1290,7 +1290,7 @@ again:
>>>  			goto out;
>>>  		}
>>>
>>> -		mlog(0, "lock %s, successfull return from ocfs2_dlm_lock\n",
>>> +		mlog(0, "lock %s, successfully return from ocfs2_dlm_lock\n",
>>>  		     lockres->l_name);
>>>
>>>  		/* At this point we've gone inside the dlm and need to
>>> @@ -2923,7 +2923,7 @@ static int ocfs2_drop_lock(struct ocfs2_super *osb,
>>>  		ocfs2_dlm_dump_lksb(&lockres->l_lksb);
>>>  		BUG();
>>>  	}
>>> -	mlog(0, "lock %s, successfull return from ocfs2_dlm_unlock\n",
>>> +	mlog(0, "lock %s, successfully return from ocfs2_dlm_unlock\n",
>>>  	     lockres->l_name);
>>>
>>>  	ocfs2_wait_on_busy_lock(lockres);
> 


-- 
~Randy
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/