Message-ID: <492B3EEF.8070404@ct.jp.nec.com>
Date: Mon, 24 Nov 2008 15:55:27 -0800
From: Hiroshi Shimamoto <h-shimamoto@ct.jp.nec.com>
User-Agent: Thunderbird 2.0.0.18 (Windows/20081105)
MIME-Version: 1.0
To: Ingo Molnar <mingo@elte.hu>
Cc: "H. Peter Anvin" <hpa@zytor.com>, Thomas Gleixner <tglx@linutronix.de>,
       linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/3] x86: signal: cosmetic unification of	sys_rt_sigreturn()
References: <49276229.9060000@ct.jp.nec.com> <492762B1.4020107@ct.jp.nec.com> <4927655B.5070906@zytor.com> <4927698C.90104@ct.jp.nec.com> <20081123095146.GR30453@elte.hu>
In-Reply-To: <20081123095146.GR30453@elte.hu>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1047
Lines: 37

Ingo Molnar wrote:
> * Hiroshi Shimamoto <h-shimamoto@ct.jp.nec.com> wrote:
> 
>> H. Peter Anvin wrote:
>>> Hiroshi Shimamoto wrote:
>>>>  
>>>> +#ifdef CONFIG_X86_32
>>>>  asmlinkage int sys_rt_sigreturn(unsigned long __unused)
>>>>  {
>>>>  	struct pt_regs *regs = (struct pt_regs *)&__unused;
>>>>  
>>>>  	return do_rt_sigreturn(regs);
>>>>  }
>>> Why not:
>>>
>>> asmlinkage int sys_rt_sigreturn(struct pt_regs regs)
>>> {
>>> 	return do_rt_sigreturn(&regs);
>>> }
>>>
>>> ...?
>> Good question. I didn't realize about that.
>> Will take a look.
> 
> I've applied your 3 patches to tip/x86/signal - please send a patch on 
> top of your current lineup, for the detail Peter pointed out.

OK, will do.
I think it's better to send a patch after unifying signal_{32|64}.c.

thanks,
Hiroshi Shimamoto
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/