Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754590AbYKYAQa (ORCPT ); Mon, 24 Nov 2008 19:16:30 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753309AbYKYAQX (ORCPT ); Mon, 24 Nov 2008 19:16:23 -0500 Received: from gir.skynet.ie ([193.1.99.77]:51362 "EHLO gir.skynet.ie" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752157AbYKYAQW (ORCPT ); Mon, 24 Nov 2008 19:16:22 -0500 Date: Tue, 25 Nov 2008 00:16:18 +0000 From: Mel Gorman To: Alan Cox Cc: petkovbb@gmail.com, sshtylyov@ru.mvista.com, linux-kernel@vger.kernel.org Subject: Re: Is the change to IDE probing really necessary? Message-ID: <20081125001618.GD8293@csn.ul.ie> References: <20081124155632.GE23190@csn.ul.ie> <20081124184321.GA8293@csn.ul.ie> <20081124185453.57ca7dcc@lxorguk.ukuu.org.uk> <20081124230948.GB8293@csn.ul.ie> <20081125000306.014f7771@lxorguk.ukuu.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline In-Reply-To: <20081125000306.014f7771@lxorguk.ukuu.org.uk> User-Agent: Mutt/1.5.13 (2006-08-11) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 20439 Lines: 386 On Tue, Nov 25, 2008 at 12:03:06AM +0000, Alan Cox wrote: > > Then can the message outputted printed out say something along those > > lines? On this particular machine, probing 0x3F resulted in a misconfigured > > That is exactly what it says at the moment. > > > machine. It's not obvious to me at all that 0x3F means probe everything, > > possibly with adverse results and 0x03 means peer at primary/secondary. > > > Which in this case resulted in no disk because the mask defaults to 0 > > now instead of 0x3 or anything else. > > The mask is set to 0 and then the master/slave are detected based upon > the presence of PCI IDE devices on the master/slave ports. > This detection was not happening but then again the proper driver was not compiled. The .config I used was very minimal and lacked most drivers. > > What you suggest for the numbers in each case is right, but it's not > > obvious. The machine might be so old that no will encounter this problem > > in practice. > > That is why pata_legacy does it automatically. Users shouldn't need to. > > > > If you want it to just work automatically use pata_legacy instead as that > > > automatically flips between probing ISA tertiary devices and leaving > > > things well alone according to the presence of PCI bus. > > > > > > > It doesn't find the disk. > > If pata_legacy fails to find the disk then please send me an lspci > -vvxxx, chances are you shouldn't be using pata_legacy or ide_generic in > the first place but have a PCI device and don't have the right driver > loaded (or we don't have a right driver in which case it needs the > heuristics fixing up) > It's included below. Earlier I said this was not on an ISA bus. This belief was enforced by CONFIG_ISA not being necessary for ide-generic to work in the past and the fact lspci lists the device. However, lspci does call it "PIIX4 ISA (rev 02)" so maybe I was getting that wrong too. It is certainly the case I was not using the correct driver. Using CONFIG_BLK_DEV_PIIX instead of CONFIG_IDE_GENERIC makes everything work as expected without having to pass special options. 00:00.0 Host bridge: Intel Corporation 440BX/ZX/DX - 82443BX/ZX/DX Host bridge (rev 03) Control: I/O- Mem+ BusMaster+ SpecCycle- MemWINV- VGASnoop- ParErr- Stepping- SERR+ FastB2B- DisINTx- Status: Cap+ 66MHz- UDF- FastB2B- ParErr- DEVSEL=medium >TAbort- SERR- Kernel driver in use: agpgart-intel Kernel modules: intel-agp 00: 86 80 90 71 06 01 10 22 03 00 00 06 00 40 00 00 10: 08 00 00 f8 00 00 00 00 00 00 00 00 00 00 00 00 20: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 30: 00 00 00 00 a0 00 00 00 00 00 00 00 00 00 00 00 40: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 50: 0c 82 00 ff 00 00 00 09 03 10 11 01 00 00 11 11 60: 10 20 20 30 40 40 40 40 00 00 00 00 00 aa 00 00 70: 20 1f 0a 78 8a 02 03 01 27 1b dc 00 10 00 00 00 80: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 90: 00 00 00 00 04 61 00 00 00 05 00 00 00 00 00 00 a0: 02 00 10 00 03 02 00 1f 00 00 00 00 00 00 00 00 b0: 80 20 00 00 30 00 00 00 00 00 68 12 20 10 00 00 c0: 00 00 00 00 00 00 00 00 18 0c 83 cd 78 00 00 00 d0: 00 00 00 00 00 00 00 00 0c 00 00 00 00 00 00 00 e0: 4c ad ff bb 8a 3e 00 80 2c d3 f7 cf 9d 3e 00 00 f0: 40 01 00 00 00 f8 00 60 20 0f 00 00 00 00 00 00 00:01.0 PCI bridge: Intel Corporation 440BX/ZX/DX - 82443BX/ZX/DX AGP bridge (rev 03) (prog-if 00 [Normal decode]) Control: I/O+ Mem+ BusMaster+ SpecCycle+ MemWINV+ VGASnoop- ParErr- Stepping- SERR- FastB2B- DisINTx- Status: Cap- 66MHz+ UDF- FastB2B- ParErr- DEVSEL=medium >TAbort- SERR- TAbort- Reset- FastB2B+ PriDiscTmr- SecDiscTmr- DiscTmrStat- DiscTmrSERREn- 00: 86 80 91 71 1f 00 20 02 03 00 04 06 00 80 01 00 10: 00 00 00 00 00 00 00 00 00 01 01 40 f0 00 a0 22 20: 00 f0 f0 f7 00 40 00 40 00 00 00 00 00 00 00 00 30: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 8c 00 40: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 50: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 60: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 70: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 80: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 90: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 a0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 b0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 c0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 d0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 e0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 f0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00:02.0 CardBus bridge: Texas Instruments PCI1450 (rev 03) Subsystem: IBM ThinkPad A21m/T20/T22 Control: I/O+ Mem+ BusMaster+ SpecCycle- MemWINV- VGASnoop- ParErr- Stepping- SERR- FastB2B- DisINTx- Status: Cap+ 66MHz- UDF- FastB2B- ParErr- DEVSEL=medium >TAbort- SERR- Reset+ 16bInt+ PostWrite- 16-bit legacy interface ports at 0001 00: 4c 10 1b ac 07 00 10 02 03 00 07 06 08 40 82 00 10: 00 00 00 50 a0 00 00 02 00 02 05 b0 00 00 00 30 20: 00 f0 ff 33 00 00 00 34 00 f0 ff 37 00 14 00 00 30: fc 14 00 00 00 1c 00 00 fc 1c 00 00 0b 01 c0 03 40: 14 10 30 01 01 00 00 00 00 00 00 00 00 00 00 00 50: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 60: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 70: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 80: 79 d0 64 08 00 00 00 00 80 80 01 80 00 10 00 00 90: c0 02 66 40 00 00 00 00 00 00 00 00 00 00 00 00 a0: 01 00 11 fe 00 00 c0 00 00 00 00 00 00 00 00 00 b0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 c0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 d0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 e0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 f0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00:02.1 CardBus bridge: Texas Instruments PCI1450 (rev 03) Subsystem: IBM ThinkPad A21m/T20/T22 Control: I/O+ Mem+ BusMaster+ SpecCycle- MemWINV- VGASnoop- ParErr- Stepping- SERR- FastB2B- DisINTx- Status: Cap+ 66MHz- UDF- FastB2B- ParErr- DEVSEL=medium >TAbort- SERR- Reset+ 16bInt+ PostWrite- 16-bit legacy interface ports at 0001 00: 4c 10 1b ac 07 00 10 02 03 00 07 06 08 40 82 00 10: 00 00 10 50 a0 00 00 02 00 06 09 b0 00 00 00 38 20: 00 f0 ff 3b 00 00 00 3c 00 f0 ff 3f 00 20 00 00 30: fc 20 00 00 00 24 00 00 fc 24 00 00 0b 02 c0 03 40: 14 10 30 01 01 00 00 00 00 00 00 00 00 00 00 00 50: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 60: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 70: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 80: 79 d0 64 08 00 00 00 00 80 80 01 80 00 10 00 00 90: c0 02 66 40 00 00 00 00 00 00 00 00 00 00 00 00 a0: 01 00 11 fe 00 00 c0 00 00 00 00 00 00 00 00 00 b0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 c0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 d0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 e0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 f0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00:03.0 Ethernet controller: Intel Corporation 82557/8/9/0/1 Ethernet Pro 100 (rev 09) Subsystem: Intel Corporation EtherExpress PRO/100+ MiniPCI Control: I/O+ Mem+ BusMaster+ SpecCycle- MemWINV+ VGASnoop- ParErr- Stepping- SERR- FastB2B- DisINTx- Status: Cap+ 66MHz- UDF- FastB2B+ ParErr- DEVSEL=medium >TAbort- SERR- TAbort- SERR- TAbort- SERR- TAbort- SERR- TAbort- SERR- TAbort- SERR- TAbort- SERR- TAbort- SERR- 00: 33 53 12 8c 07 00 30 02 11 00 00 03 08 40 00 00 10: 00 00 00 f0 00 00 00 00 00 00 00 00 00 00 00 00 20: 00 00 00 00 00 00 00 00 00 00 00 00 14 10 7f 01 30: 00 00 00 00 dc 00 00 00 00 00 00 00 0b 01 04 ff 40: 03 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 50: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 60: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 70: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 80: 02 00 10 00 03 02 00 1f 00 00 00 00 40 02 00 00 90: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 a0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 b0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 c0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 d0: 00 00 00 00 00 00 00 00 00 00 00 00 01 80 21 06 e0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 f0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 -- Mel Gorman Part-time Phd Student Linux Technology Center University of Limerick IBM Dublin Software Lab -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/