Return-Path: <linux-kernel-owner+w=401wt.eu-S1752324AbYKYHPr@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752324AbYKYHPr (ORCPT <rfc822;w@1wt.eu>);
	Tue, 25 Nov 2008 02:15:47 -0500
Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751128AbYKYHPj
	(ORCPT <rfc822;linux-kernel-outgoing>);
	Tue, 25 Nov 2008 02:15:39 -0500
Received: from mx1.suse.de ([195.135.220.2]:51495 "EHLO mx1.suse.de"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1751119AbYKYHPi (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Tue, 25 Nov 2008 02:15:38 -0500
Date: Tue, 25 Nov 2008 08:15:36 +0100
Message-ID: <s5hy6z8tgx3.wl%tiwai@suse.de>
From: Takashi Iwai <tiwai@suse.de>
To: Tino Keitel <tino.keitel@gmx.de>
Cc: linux-kernel@vger.kernel.org
Subject: Re: 2.6.28-rc regression: digital audio inactive after resume from	suspend
In-Reply-To: <20081125070312.GA6533@dose.home.local>
References: <20081124212225.GA5872@dose.home.local>
	<s5hiqqcra95.wl%tiwai@suse.de>
	<20081125070312.GA6533@dose.home.local>
User-Agent: Wanderlust/2.12.0 (Your Wildest Dreams) SEMI/1.14.6 (Maruoka)
 FLIM/1.14.7 (=?ISO-8859-4?Q?Sanj=F2?=) APEL/10.6 Emacs/22.3
 (x86_64-suse-linux-gnu) MULE/5.0 (SAKAKI)
MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 2435
Lines: 73

At Tue, 25 Nov 2008 08:03:12 +0100,
Tino Keitel wrote:
> 
> On Tue, Nov 25, 2008 at 00:10:14 +0100, Takashi Iwai wrote:
> > At Mon, 24 Nov 2008 22:22:25 +0100,
> > Tino Keitel wrote:
> > > 
> > > Hi,
> > > 
> > > the digital audio out (optical) is inactive (no red light, and
> > > therefore silent) after resume from suspend on my Mac mini Core Duo.
> > > When I disable and enable the IEC958 toggle, it works again.
> > > 
> > > This didn't happen with 2.6.27. Currently, I use 2.6.28-rc6 as of
> > > commit ged31348.
> > > 
> > > This is the hardware in lspci:
> > > 
> > > 00:1b.0 Audio device [0403]: Intel Corporation 82801G (ICH7 Family)
> > > High Definition Audio Controller [8086:27d8] (rev 02)
> > > 	Subsystem: Sigmatel Device [8384:7680]
> > > 	Flags: bus master, fast devsel, latency 0, IRQ 22
> > > 	Memory at 90440000 (64-bit, non-prefetchable) [size=16K]
> > > 	Capabilities: <access denied>
> > > 	Kernel driver in use: HDA Intel
> > > 	Kernel modules: snd-hda-intel
> > > 
> > > The dmesg output with 2.6.27 and 2.6.28-rc are here:
> > > 
> > > http://tikei.de/dmesg_2.6.27.5
> > > http://tikei.de/dmesg_2.6.28-rc6
> > 
> > Could you run alsa-info.sh with --no-upload option on both kernels
> > and attach the generated files?  The script is found at
> >     http://www.alsa-project.org/alsa-info.sh
> 
> http://tikei.de/alsa-info-2.6.27.5.txt
> http://tikei.de/alsa-info-2.6.28-broken.txt
> http://tikei.de/alsa-info-2.6.28-fixed.txt (here I unchecked/rechecked
> the IEC958 toggle)

Could you try the patch below?


thanks,

Takashi

---
diff --git a/sound/pci/hda/hda_codec.c b/sound/pci/hda/hda_codec.c
index ba1ab73..eb91641 100644
--- a/sound/pci/hda/hda_codec.c
+++ b/sound/pci/hda/hda_codec.c
@@ -1436,12 +1436,12 @@ static void set_dig_out(struct hda_codec *codec, hda_nid_t nid,
 {
 	hda_nid_t *d;
 
-	snd_hda_codec_write(codec, nid, 0, verb, val);
+	snd_hda_codec_write_cache(codec, nid, 0, verb, val);
 	d = codec->slave_dig_outs;
 	if (!d)
 		return;
 	for (; *d; d++)
-		snd_hda_codec_write(codec, *d, 0, verb, val);
+		snd_hda_codec_write_cache(codec, *d, 0, verb, val);
 }
 
 static inline void set_dig_out_convert(struct hda_codec *codec, hda_nid_t nid,
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/