Date: Tue, 25 Nov 2008 10:22:30 +0000
From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Sheng Yang <sheng@linux.intel.com>
Cc: linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org,
       Sheng Yang <sheng@linux.intel.com>
Subject: Re: [PATCH] 8250: Eliminate compile warning of 8250.c
Message-ID: <20081125102230.791fa168@lxorguk.ukuu.org.uk>
In-Reply-To: <1227585503-3833-1-git-send-email-sheng@linux.intel.com>
References: <1227585320-3711-1-git-send-email-sheng@linux.intel.com>
	<1227585503-3833-1-git-send-email-sheng@linux.intel.com>
Organization: Red Hat UK Cyf., Amberley Place, 107-111 Peascod Street,
 Windsor, Berkshire, SL4 1TE, Y Deyrnas Gyfunol. Cofrestrwyd yng Nghymru a
 Lloegr o'r rhif cofrestru 3798903
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 747
Lines: 23

On Tue, 25 Nov 2008 11:58:23 +0800
Sheng Yang <sheng@linux.intel.com> wrote:

> (Something wrong with encoding of the first mail...)
> 
> The patch based on linux-2.6 upstream and elimiate this compile warning
> info:
> 
> drivers/serial/8250.c: In function 'serial8250_shutdown':
> drivers/serial/8250.c:1612: warning: 'i' may be used uninitialized in this
> function

NAK - again.

There is no real bug here and you risk hiding future ones. It also
doesn't produce a warning with a modern gcc.

Alan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/