From: Sheng Yang <sheng@linux.intel.com>
Organization: Intel Opensource Technology Center
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Subject: Re: [PATCH] 8250: Eliminate compile warning of 8250.c
Date: Tue, 25 Nov 2008 19:32:07 +0800
User-Agent: KMail/1.10.3 (Linux/2.6.27-7-generic; KDE/4.1.3; x86_64; ; )
Cc: linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org
References: <1227585320-3711-1-git-send-email-sheng@linux.intel.com> <200811251851.44768.sheng@linux.intel.com> <20081125111342.5383c957@lxorguk.ukuu.org.uk>
In-Reply-To: <20081125111342.5383c957@lxorguk.ukuu.org.uk>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-Id: <200811251932.08050.sheng@linux.intel.com>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1139
Lines: 37

On Tuesday 25 November 2008 19:13:42 Alan Cox wrote:
> > The logic here is strange...
>
> Why
>
> > If you used old compiler, you would get a warning, and you thought that's
> > ensured we won't delete a intended assignment by mistake.
>
> No.. if you hid the warning by hacking around the compiler mistake with
> extra bogus assignments you would hide a future mistake.

OK, I got it now. 

Comparing the result of deleting a meaningful line, this modification result in 
no more warning.  And you also think one additional BUG_ON just for fixing 
compiler's mistake, so it's unacceptable. 

So leave the patch as it was. Seems many people need to upgrade compiler to 
avoid this thing. :)

-- 
regards
Yang, Sheng

>
> > If you used new compiler, you wouldn't get a warning, and you think this
> > time the compiler get it right.
>
> The compiler does now get it right - I checked.
>
> Alan

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/