Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753256AbYKYPhQ (ORCPT ); Tue, 25 Nov 2008 10:37:16 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752019AbYKYPhD (ORCPT ); Tue, 25 Nov 2008 10:37:03 -0500 Received: from mx2.mail.elte.hu ([157.181.151.9]:45076 "EHLO mx2.mail.elte.hu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751494AbYKYPhB (ORCPT ); Tue, 25 Nov 2008 10:37:01 -0500 Date: Tue, 25 Nov 2008 16:36:53 +0100 From: Ingo Molnar To: =?iso-8859-1?Q?Fr=E9d=E9ric?= Weisbecker Cc: Steven Rostedt , Linux Kernel Subject: Re: Human readable output for function return tracer Message-ID: <20081125153653.GA21001@elte.hu> References: <20081124162719.GA11532@elte.hu> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.5.18 (2008-05-17) X-ELTE-VirusStatus: clean X-ELTE-SpamScore: -1.5 X-ELTE-SpamLevel: X-ELTE-SpamCheck: no X-ELTE-SpamVersion: ELTE 2.0 X-ELTE-SpamCheck-Details: score=-1.5 required=5.9 tests=BAYES_00 autolearn=no SpamAssassin version=3.2.3 -1.5 BAYES_00 BODY: Bayesian spam probability is 0 to 1% [score: 0.0000] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1547 Lines: 40 * Fr?d?ric Weisbecker wrote: > I made a patch last evening and I almost finished implementing the > desired output. > > But while I went through, I was adding some more keywords with other > "return-function-tracing" semantics, plus the risk of confusion > resulting from the entry-on-function-for-return-tracing keywords.... > > I planned to change all the keywords according to a new name for > this tracer just after this patch. But I can't seriously submit such > a mess, even with a second patch that fixes the keywords.... > > I would like to change the name of the tracer and its keywords > before sending the output changes. > Do you agree with "full function tracer" (since we hook now on the > two sides)? "full function tracer" sounds a bit funny and quirky. How about "function call tracer"? Versus the "function tracer" or "function entry tracer" which is the lighter variant - both in name and in overhead. So we'd have: # cat /debug/tracing/available_tracers mmiotrace wakeup irqsoff function function-call sysprof sched_switch initcall nop note how intuitive it is: "function-call" is 'more' than just the plain function-tracer. It also expresses its main property: it traces the full call, entry and exit and return code as well. Hm? Ingo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/