Date: Tue, 25 Nov 2008 17:36:24 +0100
From: Ingo Molnar <mingo@elte.hu>
To: Markus Metzger <markus.t.metzger@intel.com>
Cc: hpa@zytor.com, linux-kernel@vger.kernel.org, tglx@linutronix.de,
       markus.t.metzger@gmail.com, roland@redhat.com,
       akpm@linux-foundation.org, mtk.manpages@gmail.com,
       eranian@googlemail.com, juan.villacis@intel.com
Subject: Re: [patch 5/9] x86, bts: base in-kernel ds interface on handles
Message-ID: <20081125163624.GD22504@elte.hu>
References: <20081125090125.A31137@sedona.ch.intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20081125090125.A31137@sedona.ch.intel.com>
User-Agent: Mutt/1.5.18 (2008-05-17)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 584
Lines: 17


* Markus Metzger <markus.t.metzger@intel.com> wrote:

> +static void ds_release(struct ds_tracer *tracer, enum ds_qualifier qual)
> +{
> +	if (tracer->context) {
> +		BUG_ON(tracer->context->owner[qual] != tracer);

please use WARN_ON_ONCE() instead of crashing the box. (this is true 
in a number of other places as well in ds.c)

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/