Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753904AbYKZDU0 (ORCPT ); Tue, 25 Nov 2008 22:20:26 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752923AbYKZDUP (ORCPT ); Tue, 25 Nov 2008 22:20:15 -0500 Received: from mta23.gyao.ne.jp ([125.63.38.249]:13709 "EHLO mx.gate01.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752532AbYKZDUN (ORCPT ); Tue, 25 Nov 2008 22:20:13 -0500 Date: Wed, 26 Nov 2008 12:18:50 +0900 From: Paul Mundt To: walimis Cc: Steven Rostedt , Liming Wang , Ingo Molnar , linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/1] ftrace: adding other non-leaving .text sections Message-ID: <20081126031850.GB14685@linux-sh.org> Mail-Followup-To: Paul Mundt , walimis , Steven Rostedt , Liming Wang , Ingo Molnar , linux-kernel@vger.kernel.org References: <1227666566-9044-1-git-send-email-liming.wang@windriver.com> <20081126030446.GA14685@linux-sh.org> <20081126031438.GA16166@ubuntu.mshome.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20081126031438.GA16166@ubuntu.mshome.net> User-Agent: Mutt/1.5.13 (2006-08-11) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1610 Lines: 33 On Wed, Nov 26, 2008 at 11:14:38AM +0800, walimis wrote: > On Wed, Nov 26, 2008 at 12:04:46PM +0900, Paul Mundt wrote: > >On Tue, Nov 25, 2008 at 10:03:35PM -0500, Steven Rostedt wrote: > >> > >> On Wed, 26 Nov 2008, Liming Wang wrote: > >> > >> > Please review this patch, and I don't know whether new sections will conflict > >> > with sched tracer or others. > >> > This patch is against Steven tree's tip/devel latest commit. > >> > > >> > Impact: improve recordmcount.pl > >> > > >> > Besides .text section, there are three .text sections that won't > >> > be freed after kernel booting. They are: .sched.text, .spinlock.text > >> > and .kprobes.text, which contain functions we can trace. But the last > >> > section ".kprobes.text" is particular, which has been marked as "notrace", > >> > we ignore it. Thus we add other two sections. > >> > >> Yep, only those sections that we know will not disappear are OK. I was > >> conservative with only using ".text" but I knew there were other sections > >> that were OK, so I used the hash array to make it easy to add others. > >> > >Does your .text cover .text.head by the way? > No, and not needed. Because .text.head is of booting code, to which > function tracer can't trace. > In the case of CPU hotplug it can be entered at any time. I don't see why it can't be traced from the boot CPU at least. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/