Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753278AbYKZHtx (ORCPT ); Wed, 26 Nov 2008 02:49:53 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751400AbYKZHto (ORCPT ); Wed, 26 Nov 2008 02:49:44 -0500 Received: from mx3.mail.elte.hu ([157.181.1.138]:60608 "EHLO mx3.mail.elte.hu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751239AbYKZHtn (ORCPT ); Wed, 26 Nov 2008 02:49:43 -0500 Date: Wed, 26 Nov 2008 08:49:38 +0100 From: Ingo Molnar To: Hannes Eder Cc: linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, the arch/x86 maintainers Subject: Re: [PATCH] x86: microcode: fix sparse warnings Message-ID: <20081126074938.GJ26036@elte.hu> References: <154e089b0811231149qcb31d00r5b28d55f81b8e6d0@mail.gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <154e089b0811231149qcb31d00r5b28d55f81b8e6d0@mail.gmail.com> User-Agent: Mutt/1.5.18 (2008-05-17) X-ELTE-VirusStatus: clean X-ELTE-SpamScore: -1.5 X-ELTE-SpamLevel: X-ELTE-SpamCheck: no X-ELTE-SpamVersion: ELTE 2.0 X-ELTE-SpamCheck-Details: score=-1.5 required=5.9 tests=BAYES_00 autolearn=no SpamAssassin version=3.2.3 -1.5 BAYES_00 BODY: Bayesian spam probability is 0 to 1% [score: 0.0000] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 975 Lines: 26 * Hannes Eder wrote: > Impact: make global variables and a function static > > Fix following sparse warnings: > > arch/x86/kernel/microcode_core.c:102:22: warning: symbol > 'microcode_ops' was not declared. Should it be static? > arch/x86/kernel/microcode_core.c:206:24: warning: symbol > 'microcode_pdev' was not declared. Should it be static? > arch/x86/kernel/microcode_core.c:322:6: warning: symbol > 'microcode_update_cpu' was not declared. Should it be static? > arch/x86/kernel/microcode_intel.c:468:22: warning: symbol > 'microcode_intel_ops' was not declared. Should it be static? > > Signed-off-by: Hannes Eder applied to tip/x86/sparse-fixes, thanks Hannes! Ingo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/