Date: Wed, 26 Nov 2008 11:08:59 +0100 (CET)
From: Geert Uytterhoeven <geert@linux-m68k.org>
To: Jaya Kumar <jayakumar.lkml@gmail.com>
cc: Paulius Zaleckas <paulius.zaleckas@teltonika.lt>,
       David Brownell <dbrownell@users.sourceforge.net>,
       linux-fbdev-devel@lists.sourceforge.net,
       Haavard Skinnemoen <hskinnemoen@atmel.com>, Greg KH <greg@kroah.com>,
       linux-kernel@vger.kernel.org, David Brownell <david-b@pacbell.net>,
       Ben Gardner <bgardner@wabtec.com>, Eric Miao <eric.miao@marvell.com>,
       Philipp Zabel <philipp.zabel@gmail.com>,
       Sam Ravnborg <sam@ravnborg.org>,
       linux-arm-kernel@lists.arm.linux.org.uk,
       Russell King <rmk@arm.linux.org.uk>
Subject: Re: [Linux-fbdev-devel] [RFC 2.6.27 1/1] gpiolib: add support for
 batch set of pins
In-Reply-To: <45a44e480811260118v440716bbqa8d37c8b696c148a@mail.gmail.com>
Message-ID: <Pine.LNX.4.64.0811261106180.2632@anakin>
References: <12276535632759-git-send-email-jayakumar.lkml@gmail.com>
 <492D125D.5010607@teltonika.lt> <45a44e480811260118v440716bbqa8d37c8b696c148a@mail.gmail.com>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1726
Lines: 43

On Wed, 26 Nov 2008, Jaya Kumar wrote:
> On Wed, Nov 26, 2008 at 4:09 AM, Paulius Zaleckas
> <paulius.zaleckas@teltonika.lt> wrote:
> > Jaya Kumar wrote:
> >>   * @to_irq: optional hook supporting non-static gpio_to_irq() mappings;
> >>   *   implementation may not sleep
> >>   * @dbg_show: optional routine to show contents in debugfs; default code
> >> @@ -84,6 +86,9 @@ struct gpio_chip {
> >>                                               unsigned offset, int value);
> >>       void                    (*set)(struct gpio_chip *chip,
> >>                                               unsigned offset, int value);
> >> +     void                    (*set_bus)(struct gpio_chip *chip,
> >> +                                             unsigned offset, int values,
> >
> > I think values should be unsigned
> >
> 
> Okay, can do but it is unusual no? since set uses int value, i figured
> set_bus should be similar right?

->set() sets one pin, right? So it's either 0 or 1.

->set_bus() sets multiple pins. With `int', it will fail for bit 31, as that's
the sign bit.

Perhaps you even want u32, to make it clear what's the maximum number of pins
you can set in one shot?

Gr{oetje,eeting}s,

						Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
							    -- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/