Date: Wed, 26 Nov 2008 23:48:38 +1100
From: Stephen Rothwell <sfr@canb.auug.org.au>
To: Andi Kleen <andi@firstfloor.org>
Cc: eranian@googlemail.com, linux-kernel@vger.kernel.org,
       akpm@linux-foundation.org, mingo@elte.hu, x86@kernel.org,
       eranian@gmail.com, paulus@samba.org
Subject: Re: [patch 05/24] perfmon: X86 generic code (x86)
Message-Id: <20081126234838.f13ff744.sfr@canb.auug.org.au>
In-Reply-To: <20081126122217.GW6703@one.firstfloor.org>
References: <492d0be1.09cc660a.0b75.44b7@mx.google.com>
	<20081126113309.GS6703@one.firstfloor.org>
	<20081126230529.ab37fb32.sfr@canb.auug.org.au>
	<20081126122217.GW6703@one.firstfloor.org>
Mime-Version: 1.0
Content-Type: multipart/signed; protocol="application/pgp-signature";
 micalg="PGP-SHA1";
 boundary="Signature=_Wed__26_Nov_2008_23_48_38_+1100_Kv+Qdjc/WJu=2fnJ"
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1925
Lines: 58

--Signature=_Wed__26_Nov_2008_23_48_38_+1100_Kv+Qdjc/WJu=2fnJ
Content-Type: text/plain; charset=US-ASCII
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hi Andi,

On Wed, 26 Nov 2008 13:22:17 +0100 Andi Kleen <andi@firstfloor.org> wrote:
>
> On Wed, Nov 26, 2008 at 11:05:29PM +1100, Stephen Rothwell wrote:
> >=20
> > On Wed, 26 Nov 2008 12:33:09 +0100 Andi Kleen <andi@firstfloor.org> wro=
te:
> > >
> > > > + * x86 does not need extra alignment requirements for the sampling=
 buffer
> > > > + */
> > > > +#define PFM_ARCH_SMPL_ALIGN_SIZE	0
> > > > +
> > > > +asmlinkage void  pmu_interrupt(void);
> > > > +
> > > > +static inline void pfm_arch_bv_copy(u64 *a, u64 *b, int nbits)
> > >=20
> > > All these bitmap wrappers just seem like unnecessary obfuscation.
> > > Could you just drop them and call the standard functions directly?
> >=20
> > These were added after comments from the PowerPC maintainer since how t=
he
> > bitmaps are accessed needs to be arch specific.
>=20
> Why? They should not be exported outside, so endian shouldn't matter, sho=
uld
> it?

See http://lkml.org/lkml/2008/11/9/281 and the followups.  Otherwise this
should be answered by Paul and Stephane.
--=20
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

--Signature=_Wed__26_Nov_2008_23_48_38_+1100_Kv+Qdjc/WJu=2fnJ
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)

iEYEARECAAYFAkktRaYACgkQjjKRsyhoI8yxKQCgjDPs58DxtRMEm1kHKQ8sNl60
r5UAoKio8liFaA700LGiCkCgQrMl377e
=32pE
-----END PGP SIGNATURE-----

--Signature=_Wed__26_Nov_2008_23_48_38_+1100_Kv+Qdjc/WJu=2fnJ--
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/