Date: Wed, 26 Nov 2008 14:32:13 +0100 (CET)
From: Thomas Gleixner <tglx@linutronix.de>
To: Stephen Rothwell <sfr@canb.auug.org.au>
cc: Andi Kleen <andi@firstfloor.org>, eranian@googlemail.com,
       linux-kernel@vger.kernel.org, akpm@linux-foundation.org, mingo@elte.hu,
       x86@kernel.org, eranian@gmail.com
Subject: Re: [patch 05/24] perfmon: X86 generic code (x86)
In-Reply-To: <20081126230529.ab37fb32.sfr@canb.auug.org.au>
Message-ID: <alpine.LFD.2.00.0811261430120.3325@localhost.localdomain>
References: <492d0be1.09cc660a.0b75.44b7@mx.google.com> <20081126113309.GS6703@one.firstfloor.org> <20081126230529.ab37fb32.sfr@canb.auug.org.au>
User-Agent: Alpine 2.00 (LFD 1167 2008-08-23)
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1148
Lines: 33

On Wed, 26 Nov 2008, Stephen Rothwell wrote:
> Hi Andi,
> 
> On Wed, 26 Nov 2008 12:33:09 +0100 Andi Kleen <andi@firstfloor.org> wrote:
> >
> > > + * x86 does not need extra alignment requirements for the sampling buffer
> > > + */
> > > +#define PFM_ARCH_SMPL_ALIGN_SIZE	0
> > > +
> > > +asmlinkage void  pmu_interrupt(void);
> > > +
> > > +static inline void pfm_arch_bv_copy(u64 *a, u64 *b, int nbits)
> > 
> > All these bitmap wrappers just seem like unnecessary obfuscation.
> > Could you just drop them and call the standard functions directly?
> 
> These were added after comments from the PowerPC maintainer since how the
> bitmaps are accessed needs to be arch specific.

Just because perfmon uses u64 for bitfields instead of unsigned
long, therefor it breaks on BE32 machines.

I have not yet found a good reason why it needs to use u64 instead of
using what's there already.

Thanks,

	tglx
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/