Date: Wed, 26 Nov 2008 15:13:18 +0100
From: Ingo Molnar <mingo@elte.hu>
To: eranian@googlemail.com
Cc: linux-kernel@vger.kernel.org, akpm@linux-foundation.org, x86@kernel.org,
       andi@firstfloor.org, eranian@gmail.com, sfr@canb.auug.org.au
Subject: Re: [patch 20/24] perfmon: system calls interface
Message-ID: <20081126141318.GG6562@elte.hu>
References: <492d0c0b.170e660a.15ba.ffffdabf@mx.google.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <492d0c0b.170e660a.15ba.ffffdabf@mx.google.com>
User-Agent: Mutt/1.5.18 (2008-05-17)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 746
Lines: 23


another thing:

+static inline int pfm_ctx_permissions(u32 ctx_flags)
+{
+       if (pfm_controls.task_group != PFM_GROUP_PERM_ANY
+                  && !in_group_p(pfm_controls.task_group)) {
+               PFM_DBG("user group not allowed to create a task context");
+               return -EPERM;
+       }
+       return 0;
+}

ctx_flags is unused here. If flags used used later on _then_ should it 
be added to these functions. Right now it just obscures review and 
slows down the code.

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/