Date: Wed, 26 Nov 2008 09:39:28 -0500
From: Joe Korty <joe.korty@ccur.com>
To: Alexey Dobriyan <adobriyan@gmail.com>
Cc: Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@elte.hu>,
       linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Add per-cpu indexing to /proc/timer_list
Message-ID: <20081126143928.GA16576@tsunami.ccur.com>
Reply-To: Joe Korty <joe.korty@ccur.com>
References: <20081125224439.GA24042@tsunami.ccur.com> <20081125231445.GA24326@tsunami.ccur.com> <20081126045004.GA3278@x200.localdomain>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20081126045004.GA3278@x200.localdomain>
User-Agent: Mutt/1.4.2.1i
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 951
Lines: 24

On Wed, Nov 26, 2008 at 07:50:04AM +0300, Alexey Dobriyan wrote:
> On Tue, Nov 25, 2008 at 06:14:45PM -0500, Joe Korty wrote:
> > Per-cpu indexing of /proc/timer_list.
> > 
> > /proc/timer_list, potentially a very large file, is in
> > danger of overflowing its seq_file buffer.  So 'split up'
> > the buffering on cpu ID boundaries.  This should make this
> > file more likely to be useful on largish SMP systems.
> 
> What do you mean?
> 
> You can't overflow seq_file buffer unless kmalloc() will fail large
> allocation. And changing internals doesn't change amount of stuff
> to be shown, which is the only thing which can lead to large buffer
> need.

You're right, I missed the re-malloc part.

Joe
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/