Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754137AbYKZPd7 (ORCPT ); Wed, 26 Nov 2008 10:33:59 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752500AbYKZPdu (ORCPT ); Wed, 26 Nov 2008 10:33:50 -0500 Received: from styx.suse.cz ([82.119.242.94]:40377 "EHLO mail.suse.cz" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752173AbYKZPdu (ORCPT ); Wed, 26 Nov 2008 10:33:50 -0500 Date: Wed, 26 Nov 2008 16:33:49 +0100 (CET) From: Jiri Kosina To: Jan Scholz , Tobias Mueller cc: jirislaby@gmail.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/1] HID: Apple alu wireless keyboards are bluetooth devices In-Reply-To: <87ej0ywm79.fsf@scholz.fias.uni-frankfurt.de> Message-ID: References: <1227710025-23592-1-git-send-email-Scholz@fias.uni-frankfurt.de> <1227710025-23592-2-git-send-email-Scholz@fias.uni-frankfurt.de> <87ej0ywm79.fsf@scholz.fias.uni-frankfurt.de> User-Agent: Alpine 1.10 (LNX 962 2008-03-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2790 Lines: 67 On Wed, 26 Nov 2008, Jan Scholz wrote: > Jiri Kosina writes: > > > On Wed, 26 Nov 2008, Jan Scholz wrote: > > > >> Changed HID_USB_DEVICE to HID_BLUETOOTH_DEVICE for the apple alu > >> wireless keyboards > >> Signed-off-by: Jan Scholz > >> --- > >> drivers/hid/hid-apple.c | 6 +++--- > >> drivers/hid/hid-core.c | 6 +++--- > >> 2 files changed, 6 insertions(+), 6 deletions(-) > >> > >> diff --git a/drivers/hid/hid-apple.c b/drivers/hid/hid-apple.c > >> index 9b97795..aa28aed 100644 > >> --- a/drivers/hid/hid-apple.c > >> +++ b/drivers/hid/hid-apple.c > >> @@ -400,12 +400,12 @@ static const struct hid_device_id apple_devices[] = { > >> { HID_USB_DEVICE(USB_VENDOR_ID_APPLE, USB_DEVICE_ID_APPLE_GEYSER4_HF_JIS), > >> .driver_data = APPLE_NUMLOCK_EMULATION | APPLE_HAS_FN | > >> APPLE_RDESC_JIS }, > >> - { HID_USB_DEVICE(USB_VENDOR_ID_APPLE, USB_DEVICE_ID_APPLE_ALU_WIRELESS_ANSI), > >> + { HID_BLUETOOTH_DEVICE(USB_VENDOR_ID_APPLE, USB_DEVICE_ID_APPLE_ALU_WIRELESS_ANSI), > >> .driver_data = APPLE_NUMLOCK_EMULATION | APPLE_HAS_FN }, > >> - { HID_USB_DEVICE(USB_VENDOR_ID_APPLE, USB_DEVICE_ID_APPLE_ALU_WIRELESS_ISO), > >> + { HID_BLUETOOTH_DEVICE(USB_VENDOR_ID_APPLE, USB_DEVICE_ID_APPLE_ALU_WIRELESS_ISO), > >> .driver_data = APPLE_NUMLOCK_EMULATION | APPLE_HAS_FN | > >> APPLE_ISO_KEYBOARD }, > >> - { HID_USB_DEVICE(USB_VENDOR_ID_APPLE, USB_DEVICE_ID_APPLE_ALU_WIRELESS_JIS), > >> + { HID_BLUETOOTH_DEVICE(USB_VENDOR_ID_APPLE, USB_DEVICE_ID_APPLE_ALU_WIRELESS_JIS), > >> .driver_data = APPLE_NUMLOCK_EMULATION | APPLE_HAS_FN }, > >> { HID_USB_DEVICE(USB_VENDOR_ID_APPLE, USB_DEVICE_ID_APPLE_WELLSPRING_ANSI), > >> .driver_data = APPLE_HAS_FN }, > > > > Hi Jan, > > > > shouldn't we rather have both USB and Bluetooth variants? > > > > Thanks, > > Hi Jiri, > > Hm, I thought the USB_DEVICE_ID_APPLE_ALU_{ANSI,ISO,JIS} were apples usb > aluminum keyboards (standard desktop size), while the > USB_DEVICE_ID_APPLE_ALU_WIRELESS_{ANSI,ISO,JIS} ones were the aluminum > bluetooth keyboards (notebook sized, no numeric keypad, etc). > > The one I own is a USB_DEVICE_ID_APPLE_ALU_WIRELESS_ISO, german layout, > with bluetooth, unfortunately I don't have access to a usb variant. Tobias Mueller added these device IDs, so persumably he has tested it and could provide some insight. I don't have the hardware myself, so I have no idea whether there are only Bluetooht variants, or even USB are available. Tobias? Thanks, -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/