Date: Wed, 26 Nov 2008 11:22:14 -0500
From: Christoph Hellwig <hch@infradead.org>
To: Hannes Eder <hannes@hanneseder.net>
Cc: Christoph Hellwig <hch@infradead.org>, David Chinner <david@fromorbit.com>,
       linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] [XFS] fix sparse warning
Message-ID: <20081126162214.GA10251@infradead.org>
References: <154e089b0811260754y191856bfl522f33febfc6e633@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <154e089b0811260754y191856bfl522f33febfc6e633@mail.gmail.com>
User-Agent: Mutt/1.5.18 (2008-05-17)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1034
Lines: 30

On Wed, Nov 26, 2008 at 04:54:53PM +0100, Hannes Eder wrote:
> Impact: fix sparse warning
> 
> Fix the following sparse warning:
> 
>   fs/xfs/xfs_inode.h:326:2: warning: returning void-valued expression
> 
> Signed-off-by: Hannes Eder <hannes@hanneseder.net>
> ---
>  fs/xfs/xfs_inode.h |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/fs/xfs/xfs_inode.h b/fs/xfs/xfs_inode.h
> index c6e295e..7a828cb 100644
> --- a/fs/xfs/xfs_inode.h
> +++ b/fs/xfs/xfs_inode.h
> @@ -323,7 +323,7 @@ static inline struct inode *VFS_I(struct xfs_inode *ip)
>  static inline void xfs_destroy_inode(struct xfs_inode *ip)
>  {
>  	make_bad_inode(VFS_I(ip));
> -	return destroy_inode(VFS_I(ip));
> +	destroy_inode(VFS_I(ip));
>  }

Yes, this makes sense.  Thanks for the patch.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/