MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Message-ID: <18733.49643.63081.163437@cargo.ozlabs.ibm.com>
Date: Thu, 27 Nov 2008 08:38:51 +1100
From: Paul Mackerras <paulus@samba.org>
To: avorontsov@ru.mvista.com
Cc: Trent Piepho <tpiepho@freescale.com>, linux-kernel@vger.kernel.org,
       linuxppc-dev@ozlabs.org,
       Benjamin Herrenschmidt <benh@kernel.crashing.org>,
       Grant Likely <grant.likely@secretlab.ca>
Subject: Re: [PATCH v2] of_gpio: Return GPIO flags from of_get_gpio()
In-Reply-To: <20081126162033.GA13397@oksana.dev.rtsoft.ru>
References: <20081030111500.GB22008@oksana.dev.rtsoft.ru>
	<1225418589-8545-1-git-send-email-tpiepho@freescale.com>
	<20081126162033.GA13397@oksana.dev.rtsoft.ru>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1120
Lines: 31

Anton Vorontsov writes:

> Can we apply it? Paul, Benjamin?
> 
> The patchwork url for this patch is:
> http://patchwork.ozlabs.org/patch/6650/
> 
> 
> Thanks!
> 
> >  drivers/mtd/nand/fsl_upm.c              |    2 +-
> >  drivers/net/fs_enet/fs_enet-main.c      |    2 +-
> >  drivers/net/phy/mdio-ofgpio.c           |    4 ++--
> >  drivers/of/gpio.c                       |   13 ++++++++++---
> >  drivers/serial/cpm_uart/cpm_uart_core.c |    2 +-
> >  include/linux/of_gpio.h                 |   21 +++++++++++++++++----
> >  6 files changed, 32 insertions(+), 12 deletions(-)

That would need acks from Jeff Garzik and David Woodhouse.

Alternatively you could add a new function (called, for instance,
of_get_gpio_flags) with the extra parameter to eliminate the need to
change any drivers at this stage, since they all seem to pass NULL for
the flags argument.

Paul.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/