Date: Thu, 27 Nov 2008 15:40:50 +0100 (CET)
From: Thomas Gleixner <tglx@linutronix.de>
To: David Miller <davem@davemloft.net>
cc: eranian@gmail.com, sfr@canb.auug.org.au, andi@firstfloor.org,
       linux-kernel@vger.kernel.org, akpm@linux-foundation.org, mingo@elte.hu,
       x86@kernel.org
Subject: Re: [patch 05/24] perfmon: X86 generic code (x86)
In-Reply-To: <20081127.033742.175440395.davem@davemloft.net>
Message-ID: <alpine.LFD.2.00.0811271540190.3325@localhost.localdomain>
References: <alpine.LFD.2.00.0811261727200.3325@localhost.localdomain> <7c86c4470811270151i33ffaa44mb5d9bd79f9d73968@mail.gmail.com> <alpine.LFD.2.00.0811271132290.3325@localhost.localdomain> <20081127.033742.175440395.davem@davemloft.net>
User-Agent: Alpine 2.00 (LFD 1167 2008-08-23)
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 624
Lines: 21

On Thu, 27 Nov 2008, David Miller wrote:
> From: Thomas Gleixner <tglx@linutronix.de>
> >   __attribute__ ((packed)); ???
> 
> Shouldn't be needed and this woule kill performance on RISC (every
> struct member is accessed with byte sized loads and shifts/masking).
> 
> We did this for the pfkey.h structures by accident, and I truly regret
> it.

Fair enough.

Thanks,

	tglx
 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/