Return-Path: <linux-kernel-owner+w=401wt.eu-S1752799AbYK1Mtt@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752799AbYK1Mtt (ORCPT <rfc822;w@1wt.eu>);
	Fri, 28 Nov 2008 07:49:49 -0500
Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1750894AbYK1Mtj
	(ORCPT <rfc822;linux-kernel-outgoing>);
	Fri, 28 Nov 2008 07:49:39 -0500
Received: from rcpt-expgw.biglobe.ne.jp ([133.205.19.65]:44807 "EHLO
	rcpt-expgw.biglobe.ne.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1750730AbYK1Mti (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Fri, 28 Nov 2008 07:49:38 -0500
X-Biglobe-Sender: <d-nishimura@mtf.biglobe.ne.jp>
Date: Fri, 28 Nov 2008 21:49:21 +0900
From: Daisuke Nishimura <d-nishimura@mtf.biglobe.ne.jp>
To: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
Cc: LKML <linux-kernel@vger.kernel.org>, linux-mm <linux-mm@kvack.org>,
       Balbir Singh <balbir@linux.vnet.ibm.com>,
       Pavel Emelyanov <xemul@openvz.org>, Li Zefan <lizf@cn.fujitsu.com>,
       Paul Menage <menage@google.com>, d-nishimura@mtf.biglobe.ne.jp,
       Daisuke Nishimura <nishimura@mxp.nes.nec.co.jp>
Subject: Re: [RFC][PATCH -mmotm 0/2] misc patches for memory cgroup
 hierarchy
Message-Id: <20081128214921.86c30347.d-nishimura@mtf.biglobe.ne.jp>
In-Reply-To: <20081128194938.508a3b22.kamezawa.hiroyu@jp.fujitsu.com>
References: <20081128180252.b7a73c86.nishimura@mxp.nes.nec.co.jp>
	<20081128194938.508a3b22.kamezawa.hiroyu@jp.fujitsu.com>
Reply-To: nishimura@mxp.nes.nec.co.jp
X-Mailer: Sylpheed 2.5.0rc2 (GTK+ 2.12.12; i386-redhat-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 2208
Lines: 71

On Fri, 28 Nov 2008 19:49:38 +0900
KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com> wrote:

> On Fri, 28 Nov 2008 18:02:52 +0900
> Daisuke Nishimura <nishimura@mxp.nes.nec.co.jp> wrote:
> 
> > Hi.
> > 
> > I'm writing some patches for memory cgroup hierarchy.
> > 
> > I think KAMEZAWA-san's cgroup-id patches are the most important pathes now,
> > but I post these patches as RFC before going further.
> > 
> Don't wait me ;) I'll rebase mine.
> 
I see :)

> 
> > Patch descriptions:
> > - [1/2] take account of memsw
> >     mem_cgroup_hierarchical_reclaim checks only mem->res now.
> >     It should also check mem->memsw when do_swap_account.
> > - [2/2] avoid oom
> >     In previous implementation, mem_cgroup_try_charge checked the return
> >     value of mem_cgroup_try_to_free_pages, and just retried if some pages
> >     had been reclaimed.
> >     But now, try_charge(and mem_cgroup_hierarchical_reclaim called from it)
> >     only checks whether the usage is less than the limit.
> >     I see oom easily in some tests which didn't cause oom before.
> > 
> > Both patches are for memory-cgroup-hierarchical-reclaim-v4 patch series.
> > 
> > My current plan for memory cgroup hierarchy:
> > - If hierarchy is enabled, limit of child should not exceed that of parent.
>  limit of a child or
>  limit of sum of children ?
> 
I'm sorry for my poor explanation.
I meant *max* of limits of children.

I think setting limit like

	group A (limit=1G)
		group A0 (limit=500M)
		group A1 (limit=800M)

is not wrong itself.


Thanks,
Daisuke Nishimura.

> > - Change other calls for mem_cgroup_try_to_free_page() to
> >   mem_cgroup_hierarchical_reclaim() if possible.
> > 
>  maybe makes sense.
> 
> Thanks,
> -Kame
> 
> --
> To unsubscribe, send a message with 'unsubscribe linux-mm' in
> the body to majordomo@kvack.org.  For more info on Linux MM,
> see: http://www.linux-mm.org/ .
> Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/