Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753766AbYK1SnD (ORCPT ); Fri, 28 Nov 2008 13:43:03 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752572AbYK1Smw (ORCPT ); Fri, 28 Nov 2008 13:42:52 -0500 Received: from mail.sf-mail.de ([62.27.20.61]:57270 "EHLO mail.sf-mail.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752570AbYK1Smv (ORCPT ); Fri, 28 Nov 2008 13:42:51 -0500 From: Rolf Eike Beer To: Trent Piepho Subject: Re: [PATCH] fakephp: Allocate PCI resources before adding the device Date: Fri, 28 Nov 2008 19:42:20 +0100 User-Agent: KMail/1.9.10 Cc: "Darrick J. Wong" , Alex Chiang , "linux-kernel" , Jesse Barnes , "linux-pci" References: <20081125212422.22631.69619.stgit@elm3a70.beaverton.ibm.com> <20081127015205.GG6539@plum> In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/signed; boundary="nextPart23177398.JYjr6NYphZ"; protocol="application/pgp-signature"; micalg=pgp-sha1 Content-Transfer-Encoding: 7bit Message-Id: <200811281942.31754.eike-kernel@sf-tec.de> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2218 Lines: 56 --nextPart23177398.JYjr6NYphZ Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Content-Disposition: inline Trent Piepho wrote: > On Wed, 26 Nov 2008, Darrick J. Wong wrote: > > On Wed, Nov 26, 2008 at 03:55:35PM -0700, Alex Chiang wrote: > > > > Maybe it's different on powerpc then? My pseudo-hotplugable device > > > > is also the only thing connected to the PCI-E host bus controller.= =20 > > > > At boot the controller is empty and so I think some code to enable > > > > its BARs gets skipped. But without the pci_enable_device(), I get > > > > this: > > > > > > > > 01:00.0 Signal processing controller: Freescale Semiconductor Inc > > > > Aurora Nexus Trace Interface Flags: fast devsel, IRQ 255 > > > > Memory at 40000000 (64-bit, prefetchable) [disabled] > > > > [size=3D4K] > > > > Are you referring to this? ^^^^^^^^^^ > > > > Without seeing the raw dump of the PCI config space, it looks to me like > > the memory space enable bit of the PCICMD register is unset. Probably > > the device driver should call pci_enable_device() at init time, though I > > suppose you did say earlier that there is no driver. > > Yes, that's it. It seems like since the BARs are normally enabled after a > device is scanned at boot time that they should also be enabled when a > device is found by a fakephp rescan. So I thought it seemed reasonable to > put pci_enable_device() in fakephp. No, pci_enable_device() will be called by the device driver. The hotplug=20 drivers have nothing to do with that. Eike --nextPart23177398.JYjr6NYphZ Content-Type: application/pgp-signature; name=signature.asc Content-Description: This is a digitally signed message part. -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.9 (GNU/Linux) iEUEABECAAYFAkkwO5cACgkQXKSJPmm5/E7lawCfVhN7ISaBv1KbcNdrJv/+nPmm otoAljkc52pY7WzTqBfDJF6VVoBjQR8= =IRcG -----END PGP SIGNATURE----- --nextPart23177398.JYjr6NYphZ-- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/